Skip to content

Commit e736e43

Browse files
fix(tests): more careful server instantiation
1 parent 6d76607 commit e736e43

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

test/cases/fetch-event-server/test.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,17 @@ export const enableFeatures = ['http', 'fetch-event'];
88
export const worldName = 'test3';
99

1010
export async function test(instance) {
11-
const server = new HTTPServer(instance.incomingHandler);
12-
let port = await getRandomPort();
13-
server.listen(port);
14-
11+
let server;
1512
try {
13+
server = new HTTPServer(instance.incomingHandler);
14+
let port = await getRandomPort();
15+
server.listen(port);
1616
const resp = await fetch(`http://localhost:${port}`);
1717
const text = await resp.text();
1818
strictEqual(text, 'Hello World');
1919
} finally {
20-
server.stop();
20+
if (server) {
21+
server.stop();
22+
}
2123
}
2224
}

test/cases/http-server/test.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,17 @@ export const enableFeatures = ['http'];
88
export const worldName = 'test3';
99

1010
export async function test(instance) {
11-
const server = new HTTPServer(instance.incomingHandler);
12-
let port = await getRandomPort();
13-
server.listen(port);
14-
11+
let server;
1512
try {
13+
server = new HTTPServer(instance.incomingHandler);
14+
let port = await getRandomPort();
15+
server.listen(port);
1616
const resp = await fetch(`http://localhost:${port}`);
1717
const text = await resp.text();
1818
strictEqual(text, 'Hello world!');
1919
} finally {
20-
server.stop();
20+
if (server) {
21+
server.stop();
22+
}
2123
}
2224
}

0 commit comments

Comments
 (0)