tests: add duplicated function name test

Author: s.vanriessen

crates/spidermonkey-embedding-splicer/src/bindgen.rs

@@ -1300,12 +1300,11 @@ fn binding_name(func_name: &str, iface_name: &Option<String>) -> String {
 }
 
 fn binding_name_import(func_name: &str, iface_name: &Option<String>, import_name: &str) -> String {
-    let valid_import = import_name
-        .chars()
-        .map(|c| if c.is_alphanumeric() { c } else { '_' })
-        .collect::<String>();
-
     if import_name != "<<INVALID>>" {
+        let valid_import = import_name
+            .chars()
+            .map(|c| if c.is_alphanumeric() { c } else { '_' })
+            .collect::<String>();
         format!("{valid_import}${func_name}")
     } else if let Some(iface_name) = iface_name {
         format!("{iface_name}${func_name}")

test/bindings.js

@@ -96,7 +96,7 @@ suite('Bindings', async () => {
         for (let [impt] of imports) {
           if (impt.startsWith('wasi:')) continue;
           if (impt.startsWith('[')) impt = impt.slice(impt.indexOf(']') + 1);
-          let importName = impt.split('/').pop();
+          let importName = impt.replace('/', '-');
           if (importName === 'test') importName = 'imports';
           map[impt] = `../../cases/${name}/${importName}.js`;
         }

test/cases/import-duplicated-interface/local:http-request-http.js

@@ -0,0 +1,3 @@
+export function run(endpoint) {
+  return endpoint;
+}

test/cases/import-duplicated-interface/local:http-request-part-two-http.js

@@ -0,0 +1,3 @@
+export function run(endpoint) {
+  return endpoint;
+}

test/cases/import-duplicated-interface/source.js

@@ -0,0 +1,13 @@
+import * as $local$e1ab0bfa$1 from 'local:http-request/http';
+import * as $local$15f12255$1 from 'local:http-request-part-two/http';
+
+export function call(parameters) {
+  console.log('call called with', parameters);
+  // $local$e1ab0bfa$1.import.run('http://example.com');
+  // $local$15f12255$1.import.run('http://example.com');
+  return parameters;
+}
+
+export const actions = {
+  call,
+};

test/cases/import-duplicated-interface/test.js

@@ -0,0 +1,18 @@
+import { strictEqual } from 'node:assert';
+
+export function test(instance, args) {
+  strictEqual(
+    instance['actions'].call({
+      actionId: '123',
+      payload: { input: '' },
+    }),
+    ''
+  );
+  strictEqual(
+    instance['actions'].instance.call({
+      actionId: '123',
+      payload: { input: '' },
+    }),
+    'http://example.com'
+  );
+}

test/cases/import-duplicated-interface/wit/deps/local-http-request-part-two/package.wit

@@ -0,0 +1,6 @@
+package local:http-request-part-two;
+
+interface http {
+  run: func(endpoint: string) -> result<string, string>;
+}
+

test/cases/import-duplicated-interface/wit/deps/local-http-request/package.wit

@@ -0,0 +1,6 @@
+package local:http-request;
+
+interface http {
+  run: func(endpoint: string) -> result<string, string>;
+}
+

test/cases/import-duplicated-interface/wit/world.wit

@@ -0,0 +1,27 @@
+package local:custom;
+
+interface actions {
+    type json-string = string;
+
+    record payload {
+        input: json-string,
+    }
+
+    record input {
+        action-id: string,
+        payload: payload,
+    }
+
+    record output {
+        %result: json-string,
+    }
+
+    call: func(input: input) -> result<output, string>;
+}
+
+world main {
+    import local:http-request/http;
+    import local:http-request-part-two/http;
+
+    export actions;
+}