Clippy fixes. (#1122)

Fix some miscellaneous warnings.

Author: sunfishcode

Cargo.toml

@@ -278,4 +278,5 @@ check-cfg = [
     'cfg(thumb_mode)',
     'cfg(wasi)',
     'cfg(wasi_ext)',
+    'cfg(target_arch, values("xtensa"))',
 ]

src/backend/linux_raw/conv.rs

@@ -107,14 +107,14 @@ pub(super) fn pass_usize<'a, Num: ArgNumber>(t: usize) -> ArgReg<'a, Num> {
 
 impl<'a, Num: ArgNumber, T> From<*mut T> for ArgReg<'a, Num> {
     #[inline]
-    fn from(c: *mut T) -> ArgReg<'a, Num> {
+    fn from(c: *mut T) -> Self {
         raw_arg(c.cast())
     }
 }
 
 impl<'a, Num: ArgNumber, T> From<*const T> for ArgReg<'a, Num> {
     #[inline]
-    fn from(c: *const T) -> ArgReg<'a, Num> {
+    fn from(c: *const T) -> Self {
         let mut_ptr = c as *mut T;
         raw_arg(mut_ptr.cast())
     }

src/backend/linux_raw/param/auxv.rs

@@ -270,9 +270,7 @@ fn init_auxv() {
 /// must be prepared for initialization to be skipped.
 #[cold]
 fn maybe_init_auxv() {
-    if let Ok(()) = init_auxv_impl() {
-        return;
-    }
+    let _ = init_auxv_impl();
 }
 
 /// If we don't have "use-explicitly-provided-auxv" or "use-libc-auxv", we

src/backend/linux_raw/process/syscalls.rs

@@ -313,7 +313,7 @@ pub(crate) fn getrlimit(limit: Resource) -> Rlimit {
 #[inline]
 pub(crate) fn setrlimit(limit: Resource, new: Rlimit) -> io::Result<()> {
     unsafe {
-        let lim = rlimit_to_linux(new.clone());
+        let lim = rlimit_to_linux(new);
         match ret(syscall_readonly!(
             __NR_prlimit64,
             c_uint(0),

src/process/sched.rs

@@ -80,7 +80,7 @@ impl fmt::Debug for CpuSet {
     fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(fmt, "CpuSet {{")?;
         let mut first = true;
-        for i in 0..CpuSet::MAX_CPU {
+        for i in 0..Self::MAX_CPU {
             if self.is_set(i) {
                 if first {
                     write!(fmt, " ")?;
@@ -97,7 +97,7 @@ impl fmt::Debug for CpuSet {
 
 impl hash::Hash for CpuSet {
     fn hash<H: hash::Hasher>(&self, state: &mut H) {
-        for i in 0..CpuSet::MAX_CPU {
+        for i in 0..Self::MAX_CPU {
             self.is_set(i).hash(state);
         }
     }

src/thread/clock.rs

@@ -103,13 +103,13 @@ pub enum NanosleepRelativeResult {
 impl fmt::Debug for NanosleepRelativeResult {
     fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            NanosleepRelativeResult::Ok => fmt.write_str("Ok"),
-            NanosleepRelativeResult::Interrupted(remaining) => write!(
+            Self::Ok => fmt.write_str("Ok"),
+            Self::Interrupted(remaining) => write!(
                 fmt,
                 "Interrupted(Timespec {{ tv_sec: {:?}, tv_nsec: {:?} }})",
                 remaining.tv_sec, remaining.tv_nsec
             ),
-            NanosleepRelativeResult::Err(err) => write!(fmt, "Err({:?})", err),
+            Self::Err(err) => write!(fmt, "Err({:?})", err),
         }
     }
 }

tests/thread/futex.rs

@@ -38,7 +38,7 @@ fn test_wait_wake() {
         move || {
             std::thread::sleep(std::time::Duration::from_millis(1));
             lock.store(1, Ordering::SeqCst);
-            futex::wake(&lock, FutexFlags::empty(), 1);
+            futex::wake(&lock, FutexFlags::empty(), 1).unwrap();
 
             std::thread::sleep(std::time::Duration::from_millis(50));
             match futex::wait(&lock, FutexFlags::empty(), 1, None) {
@@ -58,7 +58,7 @@ fn test_wait_wake() {
     }
 
     lock.store(2, Ordering::SeqCst);
-    futex::wake(&lock, FutexFlags::empty(), 1);
+    futex::wake(&lock, FutexFlags::empty(), 1).unwrap();
 
     other.join().unwrap();
 }