Code review feedback.

Author: peterhuene

crates/wac-graph/src/graph.rs

@@ -871,11 +871,11 @@ impl CompositionGraph {
     ///
     /// If an edge already exists between the argument and the instantiation node, this method
     /// returns `Ok(_)`.
-    pub fn connect_argument(
+    pub fn set_instantiation_argument(
         &mut self,
-        argument: NodeId,
         instantiation: NodeId,
         argument_name: &str,
+        argument: NodeId,
     ) -> GraphResult<()> {
         fn add_edge(
             graph: &mut CompositionGraph,
@@ -1007,11 +1007,11 @@ impl CompositionGraph {
     ///
     /// If the argument is not connected to the instantiation node, then this
     /// function will be a no-op.
-    pub fn disconnect_argument(
+    pub fn unset_instantiation_argument(
         &mut self,
-        argument: NodeId,
         instantiation: NodeId,
         argument_name: &str,
+        argument: NodeId,
     ) -> GraphResult<()> {
         // Ensure the target is an instantiation node
         let instantiation_data = self

crates/wac-graph/src/lib.rs

@@ -27,8 +27,8 @@
 //! // Instantiate package `my:package2`
 //! let instantiation2 = graph.instantiate(package2)?;
 //!
-//! // Connect `a` to the argument `b` of the instantiation
-//! graph.connect_argument(a, instantiation2, "b")?;
+//! // Set argument `b` of the instantiation of `my:package2` to `a`
+//! graph.set_instantiation_argument(instantiation2, "b", a)?;
 //!
 //! // Finally, encode the graph into a new component
 //! let bytes = graph.encode(EncodeOptions::default())?;

crates/wac-graph/tests/encoding.rs

@@ -209,7 +209,7 @@ impl GraphFile {
                 format!("invalid target node index {target} referenced in argument {index} for test case `{test_case}`", target = argument.target)
             }).copied()?;
 
-            graph.connect_argument(source, target, &argument.name).with_context(|| {
+            graph.set_instantiation_argument(target, &argument.name, source).with_context(|| {
                 format!("failed to add argument edge from source node {source} to target node {target} referenced in argument {index} for test case `{test_case}`", source = argument.source, target = argument.target)
             })?;
         }

crates/wac-types/src/core.rs

@@ -1,6 +1,5 @@
-use std::fmt;
-
 use indexmap::IndexMap;
+use std::fmt;
 
 /// Represents a core module type.
 #[derive(Debug, Clone, Default)]