Skip to content

Commit 1f4580f

Browse files
authored
Enable CI wasi test suite for x86-32 classic/fast interpreter (#1866)
The original CI didn't actually run wasi test suite for x86-32 since the `TEST_ON_X86_32=true` isn't written into $GITHUB_ENV. And refine the error output when failed to link import global.
1 parent 7401718 commit 1f4580f

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/compilation_on_android_ubuntu.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,8 @@ jobs:
424424

425425
- name: set env variable(if x86_32 test needed)
426426
if: >
427-
(matrix.test_option == '$DEFAULT_TEST_OPTIONS' || matrix.test_option == '$THREADS_TEST_OPTIONS')
427+
(matrix.test_option == '$DEFAULT_TEST_OPTIONS' || matrix.test_option == '$THREADS_TEST_OPTIONS'
428+
|| matrix.test_option == '$WASI_TEST_OPTIONS')
428429
&& matrix.running_mode != 'fast-jit' && matrix.running_mode != 'jit'
429430
run: echo "TEST_ON_X86_32=true" >> $GITHUB_ENV
430431

core/iwasm/aot/aot_runtime.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,7 @@ check_linked_symbol(AOTModule *module, char *error_buf, uint32 error_buf_size)
987987
AOTImportGlobal *global = module->import_globals + i;
988988
if (!global->is_linked) {
989989
set_error_buf_v(error_buf, error_buf_size,
990-
"warning: failed to link import global (%s, %s)",
990+
"failed to link import global (%s, %s)",
991991
global->module_name, global->global_name);
992992
return false;
993993
}

core/iwasm/interpreter/wasm_runtime.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1252,7 +1252,7 @@ check_linked_symbol(WASMModuleInstance *module_inst, char *error_buf,
12521252
#else
12531253
#if WASM_ENABLE_WAMR_COMPILER == 0
12541254
set_error_buf_v(error_buf, error_buf_size,
1255-
"warning: failed to link import global (%s, %s)",
1255+
"failed to link import global (%s, %s)",
12561256
global->module_name, global->field_name);
12571257
return false;
12581258
#else

0 commit comments

Comments
 (0)