Skip to content

Commit 6bfc088

Browse files
author
Georgii Rylov
committed
Calculate func_index instead of adding an extra field to wasm frame
1 parent 9ff8052 commit 6bfc088

4 files changed

Lines changed: 4 additions & 10 deletions

File tree

core/iwasm/interpreter/wasm_interp.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ typedef struct WASMInterpFrame {
2626
/* Instruction pointer of the bytecode array. */
2727
uint8 *ip;
2828

29-
uint32 func_index;
30-
3129
#if WASM_ENABLE_FAST_JIT != 0
3230
uint8 *jitted_return_addr;
3331
#endif

core/iwasm/interpreter/wasm_interp_classic.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1264,11 +1264,9 @@ wasm_interp_call_func_native(WASMModuleInstance *module_inst,
12641264
init_frame_refs(frame_ref, local_cell_num, cur_func);
12651265
#endif
12661266

1267-
cur_func_index = (uint32)(cur_func - module_inst->e->functions);
1268-
frame->func_index = cur_func_index;
1269-
12701267
wasm_exec_env_set_cur_frame(exec_env, frame);
12711268

1269+
cur_func_index = (uint32)(cur_func - module_inst->e->functions);
12721270
bh_assert(cur_func_index < module_inst->module->import_function_count);
12731271
if (!func_import->call_conv_wasm_c_api) {
12741272
native_func_pointer = module_inst->import_func_ptrs[cur_func_index];

core/iwasm/interpreter/wasm_interp_fast.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1205,11 +1205,9 @@ wasm_interp_call_func_native(WASMModuleInstance *module_inst,
12051205
init_frame_refs(frame->frame_ref, local_cell_num, cur_func);
12061206
#endif
12071207

1208-
cur_func_index = (uint32)(cur_func - module_inst->e->functions);
1209-
frame->func_index = cur_func_index;
1210-
12111208
wasm_exec_env_set_cur_frame(exec_env, frame);
12121209

1210+
cur_func_index = (uint32)(cur_func - module_inst->e->functions);
12131211
bh_assert(cur_func_index < module_inst->module->import_function_count);
12141212
if (!func_import->call_conv_wasm_c_api) {
12151213
native_func_pointer = module_inst->import_func_ptrs[cur_func_index];
@@ -6034,7 +6032,6 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
60346032

60356033
/* Initialize the interpreter context. */
60366034
frame->function = cur_func;
6037-
frame->func_index = (uint32)(cur_func - module->e->functions);
60386035
frame_ip = wasm_get_func_code(cur_func);
60396036
frame_ip_end = wasm_get_func_code_end(cur_func);
60406037

core/iwasm/interpreter/wasm_runtime.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4222,7 +4222,8 @@ wasm_interp_iterate_callstack(WASMExecEnv *exec_env,
42224222
&& (uint8_t *)cur_frame + sizeof(WASMInterpFrame) <= top_boundary) {
42234223
record_frame.instance = module_inst;
42244224
record_frame.module_offset = 0;
4225-
record_frame.func_index = cur_frame->func_index;
4225+
// It's safe to dereference module_inst->e because "e" is asigned only once in wasm_instantiate
4226+
record_frame.func_index = (uint32)(cur_frame->function - module_inst->e->functions);
42264227
if (!frame_handler(user_data, &record_frame)) {
42274228
break;
42284229
}

0 commit comments

Comments
 (0)