Skip to content

Commit 8c4c570

Browse files
committed
Improve run.py of regression
1. Fix script interruption on case failure 2. improve statistics logic 3. enable select specific issue ids
1 parent 1e41519 commit 8c4c570

1 file changed

Lines changed: 77 additions & 37 deletions

File tree

  • tests/regression/ba-issues

tests/regression/ba-issues/run.py

Lines changed: 77 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@
1010
import subprocess
1111
import glob
1212
import re
13-
from typing import Dict
13+
import argparse
14+
15+
from typing import Dict, Optional, List, Any
1416

1517
WORK_DIR = os.getcwd()
1618
TEST_WASM_COMMAND = (
@@ -45,7 +47,12 @@ def dump_error_log(failing_issue_id, command_lists, exit_code_cmp, stdout_cmp):
4547
)
4648

4749

48-
def get_issue_ids_should_test():
50+
def get_issue_ids_should_test(selected_ids: Optional[List[int]] = None):
51+
"""Find all issue IDs that should be tested in folder issues."""
52+
# If specific issue IDs are provided, return them as a set
53+
if selected_ids:
54+
return set(selected_ids)
55+
4956
# Define the path pattern
5057
path_pattern = "issues/issue-*"
5158

@@ -60,8 +67,8 @@ def get_issue_ids_should_test():
6067
# Extract the issue number using regular expression
6168
match = re.search(pattern, dir_path)
6269
if match:
63-
issue_number = match.group(1)
64-
issue_numbers.add(int(issue_number))
70+
issue_number = int(match.group(1))
71+
issue_numbers.add(issue_number)
6572

6673
# Print the set of issue numbers
6774
return issue_numbers
@@ -77,10 +84,10 @@ def get_and_check(d, key, default=None, nullable=False):
7784

7885

7986
def run_and_compare_results(
80-
passed_ids, failed_ids, issue_id, cmd, description, ret_code, stdout_content
81-
):
87+
issue_id, cmd, description, ret_code, stdout_content
88+
) -> bool:
8289
print(f"####################################")
83-
print(f"test BA issue #{issue_id} `{description}`: {cmd}")
90+
print(f"test BA issue #{issue_id} `{description}`...")
8491
command_list = cmd.split()
8592
result = subprocess.run(
8693
command_list,
@@ -95,35 +102,33 @@ def run_and_compare_results(
95102

96103
exit_code_cmp = f"exit code (actual, expected) : {actual_exit_code, ret_code}"
97104
stdout_cmp = f"stdout (actual, expected) : {actual_output, stdout_content}"
98-
print(exit_code_cmp)
99-
print(stdout_cmp)
100105

101106
if actual_exit_code == ret_code and (
102107
actual_output == stdout_content
103-
or (stdout_content == "Compile success"
104-
and actual_output.find(stdout_content) != -1)
108+
or (
109+
stdout_content == "Compile success"
110+
and actual_output.find(stdout_content) != -1
111+
)
105112
or (len(stdout_content) > 30 and actual_output.find(stdout_content) != -1)
106113
):
107-
passed_ids.add(issue_id)
108114
print("== PASS ==")
115+
return True
109116
else:
110-
failed_ids.add(issue_id)
117+
print(cmd)
118+
print(exit_code_cmp)
119+
print(stdout_cmp)
111120
print(f"== FAILED: {issue_id} ==")
112121
dump_error_log(
113122
issue_id,
114123
command_list,
115124
exit_code_cmp,
116125
stdout_cmp,
117126
)
118-
119-
print("")
127+
return False
120128

121129

122-
def run_issue_test_wamrc(
123-
passed_ids, failed_ids, issue_id, compile_options, stdout_only_cmp_last_line=False
124-
):
130+
def run_issue_test_wamrc(issue_id, compile_options, stdout_only_cmp_last_line=False):
125131
compiler = get_and_check(compile_options, "compiler")
126-
only_compile = get_and_check(compile_options, "only compile")
127132
in_file = get_and_check(compile_options, "in file")
128133
out_file = get_and_check(compile_options, "out file")
129134
options = get_and_check(compile_options, "options")
@@ -145,14 +150,10 @@ def run_issue_test_wamrc(
145150
compiler=compiler, options=options, out_file=out_file_path, in_file=in_file_path
146151
)
147152

148-
run_and_compare_results(
149-
passed_ids, failed_ids, issue_id, cmd, description, ret_code, stdout_content
150-
)
151-
152-
return only_compile
153+
return run_and_compare_results(issue_id, cmd, description, ret_code, stdout_content)
153154

154155

155-
def run_issue_test_iwasm(passed_ids, failed_ids, issue_id, test_case):
156+
def run_issue_test_iwasm(issue_id, test_case) -> bool:
156157
runtime = get_and_check(test_case, "runtime")
157158
mode = get_and_check(test_case, "mode")
158159
file = get_and_check(test_case, "file")
@@ -194,17 +195,19 @@ def run_issue_test_iwasm(passed_ids, failed_ids, issue_id, test_case):
194195
argument=argument,
195196
)
196197

197-
run_and_compare_results(
198-
passed_ids, failed_ids, issue_id, cmd, description, ret_code, stdout_content
199-
)
198+
return run_and_compare_results(issue_id, cmd, description, ret_code, stdout_content)
200199

201200

202-
def process_and_run_test_cases(data: Dict[str, Dict]):
203-
issue_ids_should_test = get_issue_ids_should_test()
201+
def process_and_run_test_cases(
202+
data: Dict[str, Dict], selected_ids: Optional[List[int]] = None
203+
):
204+
issue_ids_should_test = get_issue_ids_should_test(selected_ids)
204205

205206
passed_ids = set()
206207
failed_ids = set()
208+
missed_ids = set()
207209

210+
# Iterate through each test case in the json data
208211
for test_case in data.get("test cases", []):
209212
is_deprecated = get_and_check(test_case, "deprecated")
210213
issue_ids = get_and_check(test_case, "ids", default=[])
@@ -214,33 +217,70 @@ def process_and_run_test_cases(data: Dict[str, Dict]):
214217
continue
215218

216219
compile_options = get_and_check(test_case, "compile_options", nullable=True)
220+
217221
for issue_id in issue_ids:
222+
if issue_id not in issue_ids_should_test:
223+
missed_ids.add(issue_id)
224+
continue
225+
226+
# cross out the this issue_id in the should test set
227+
issue_ids_should_test.remove(issue_id)
228+
218229
only_compile = False
230+
219231
# if this issue needs to test wamrc to compile the test case first
220232
if compile_options:
221233
only_compile = compile_options["only compile"]
222-
run_issue_test_wamrc(passed_ids, failed_ids, issue_id, compile_options)
234+
compile_res = run_issue_test_wamrc(issue_id, compile_options)
235+
if only_compile:
236+
if compile_res:
237+
passed_ids.add(issue_id)
238+
else:
239+
failed_ids.add(issue_id)
240+
continue
241+
else:
242+
# if compile success, then continue to test iwasm
243+
if not compile_res:
244+
failed_ids.add(issue_id)
245+
continue
223246

224247
# if this issue requires to test iwasm to run the test case
225248
if not only_compile:
226-
run_issue_test_iwasm(passed_ids, failed_ids, issue_id, test_case)
227-
228-
# cross out the this issue_id in the should test set
229-
issue_ids_should_test.remove(issue_id)
249+
if run_issue_test_iwasm(issue_id, test_case):
250+
passed_ids.add(issue_id)
251+
else:
252+
failed_ids.add(issue_id)
230253

231254
total = len(passed_ids) + len(failed_ids)
232255
passed = len(passed_ids)
233256
failed = len(failed_ids)
257+
missed = len(missed_ids)
234258
issue_ids_should_test = (
235259
issue_ids_should_test if issue_ids_should_test else "no more"
236260
)
261+
print(f"####################################")
237262
print(f"==== Test results ====")
238-
print(f" Total: {total}")
263+
print(f" Total: {total}")
239264
print(f" Passed: {passed}")
240265
print(f" Failed: {failed}")
266+
print(f" missed: {missed}")
267+
print(f" Left Issues: {issue_ids_should_test}")
241268

242269

243270
def main():
271+
parser = argparse.ArgumentParser(description="Run BA issue tests.")
272+
parser.add_argument(
273+
"-i",
274+
"--issues",
275+
type=str,
276+
help="Comma separated list of issue ids to run, e.g. 1,2,3. Default: all.",
277+
)
278+
args = parser.parse_args()
279+
280+
selected_ids = None
281+
if args.issues:
282+
selected_ids = [int(x) for x in args.issues.split(",") if x.strip().isdigit()]
283+
244284
# Path to the JSON file
245285
file_path = "running_config.json"
246286

@@ -256,7 +296,7 @@ def main():
256296
os.remove(LOG_FILE)
257297

258298
# Process the data
259-
process_and_run_test_cases(data)
299+
process_and_run_test_cases(data, selected_ids)
260300

261301

262302
if __name__ == "__main__":

0 commit comments

Comments
 (0)