Appease clippy

Author: lann

crates/wasm-pkg-client/src/caching/file.rs

@@ -81,8 +81,7 @@ impl Cache for FileCache {
         let mut file = tokio::fs::File::create(&path).await.map_err(|e| {
             Error::CacheError(anyhow::anyhow!("Unable to create file for cache {e}"))
         })?;
-        let mut buf =
-            StreamReader::new(data.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e)));
+        let mut buf = StreamReader::new(data.map_err(std::io::Error::other));
         tokio::io::copy(&mut buf, &mut file)
             .await
             .map_err(|e| Error::CacheError(e.into()))

crates/wasm-pkg-client/src/lib.rs

@@ -170,10 +170,9 @@ impl Client {
             let (mut data, p, v) = tokio::task::spawn_blocking(|| resolve_package(data))
                 .await
                 .map_err(|e| {
-                    crate::Error::IoError(std::io::Error::new(
-                        std::io::ErrorKind::Other,
-                        format!("Error when performing blocking IO: {e:?}"),
-                    ))
+                    crate::Error::IoError(std::io::Error::other(format!(
+                        "Error when performing blocking IO: {e:?}"
+                    )))
                 })??;
             // We must rewind the reader because we read to the end to parse the component.
             data.rewind().await?;

crates/wasm-pkg-client/src/release.rs

@@ -26,7 +26,7 @@ impl Ord for VersionInfo {
 
 impl PartialOrd for VersionInfo {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        Some(self.version.cmp(&other.version))
+        Some(self.cmp(other))
     }
 }
 

crates/wasm-pkg-common/src/metadata.rs

@@ -63,7 +63,7 @@ impl RegistryMetadata {
     }
 
     /// Returns an iterator of protocols configured by the registry.
-    pub fn configured_protocols(&self) -> impl Iterator<Item = Cow<str>> {
+    pub fn configured_protocols(&self) -> impl Iterator<Item = Cow<'_, str>> {
         let mut protos: BTreeSet<String> = self.protocol_configs.keys().cloned().collect();
         // Backward-compatibility aliases
         if self.oci_registry.is_some() || self.oci_namespace_prefix.is_some() {

crates/wasm-pkg-core/src/resolver.rs

@@ -126,9 +126,9 @@ impl RegistryResolution {
             )
             .await?;
 
-        Ok(tokio_util::io::StreamReader::new(stream.map_err(|e| {
-            std::io::Error::new(std::io::ErrorKind::Other, e)
-        })))
+        Ok(tokio_util::io::StreamReader::new(
+            stream.map_err(std::io::Error::other),
+        ))
     }
 }
 
@@ -181,7 +181,7 @@ impl DependencyResolution {
     }
 
     /// Decodes the resolved dependency.
-    pub async fn decode(&self) -> Result<DecodedDependency> {
+    pub async fn decode(&self) -> Result<DecodedDependency<'_>> {
         // If the dependency path is a directory, assume it contains wit to parse as a package.
         let bytes = match self {
             DependencyResolution::Local(LocalResolution { path, .. })