wasm-tools, wit-parser: add --all-features to enable all features gated with @unstable (#1599)

* wasm-tools, wit-parser: add --all-features to enable all features gated with @unstable

* wasm-tools: put logic for --all-features into WitResolve::resolve_with_features

* wit-parser, wasm-tools: --all-features is now an alias for --features *

* wasm-tools, wit-parser: --features . instead of * to imply --all-features

* wasm-tools: document --features . as alias for --all-features

* tests/cli: add tests for --all-features and --features .

* wasm-tools: rustfmt

* wasm-tools: remove --features . as alias for --all-features

Author: ydnar

crates/wit-parser/src/resolve.rs

@@ -74,6 +74,10 @@ pub struct Resolve {
     /// set.
     #[cfg_attr(feature = "serde", serde(skip))]
     pub features: IndexSet<String>,
+
+    /// Activate all features for this [`Resolve`].
+    #[cfg_attr(feature = "serde", serde(skip))]
+    pub all_features: bool,
 }
 
 /// A WIT package within a `Resolve`.
@@ -1142,7 +1146,7 @@ impl Resolve {
     fn include_stability(&self, stability: &Stability) -> bool {
         match stability {
             Stability::Stable { .. } | Stability::Unknown => true,
-            Stability::Unstable { feature } => self.features.contains(feature),
+            Stability::Unstable { feature } => self.features.contains(feature) || self.all_features,
         }
     }
 }

src/bin/wasm-tools/component.rs

@@ -182,11 +182,19 @@ struct WitResolve {
     /// items are otherwise hidden by default.
     #[clap(long)]
     features: Vec<String>,
+
+    /// Enable all features when parsing the `wit` option.
+    ///
+    /// This flag enables all `@unstable` features in WIT documents where the
+    /// items are otherwise hidden by default.
+    #[clap(long)]
+    all_features: bool,
 }
 
 impl WitResolve {
-    fn resolve_with_features(features: &[String]) -> Resolve {
+    fn resolve_with_features(features: &[String], all_features: bool) -> Resolve {
         let mut resolve = Resolve::default();
+        resolve.all_features = all_features;
         for feature in features {
             for f in feature.split_whitespace() {
                 for f in f.split(',').filter(|s| !s.is_empty()) {
@@ -198,7 +206,7 @@ impl WitResolve {
     }
 
     fn load(&self) -> Result<(Resolve, Vec<PackageId>)> {
-        let mut resolve = Self::resolve_with_features(&self.features);
+        let mut resolve = Self::resolve_with_features(&self.features, self.all_features);
         let (pkg_ids, _) = resolve.push_path(&self.wit)?;
         Ok((resolve, pkg_ids))
     }
@@ -494,6 +502,13 @@ pub struct WitOpts {
     /// items are otherwise hidden by default.
     #[clap(long)]
     features: Vec<String>,
+
+    /// Enable all features when parsing the `wit` option.
+    ///
+    /// This flag enables all `@unstable` features in WIT documents where the
+    /// items are otherwise hidden by default.
+    #[clap(long)]
+    all_features: bool,
 }
 
 impl WitOpts {
@@ -524,7 +539,8 @@ impl WitOpts {
         // `parse_wit_from_path`.
         if let Some(input) = &self.input {
             if input.is_dir() {
-                let mut resolve = WitResolve::resolve_with_features(&self.features);
+                let mut resolve =
+                    WitResolve::resolve_with_features(&self.features, self.all_features);
                 let (pkg_ids, _) = resolve.push_dir(&input)?;
                 return Ok(DecodedWasm::WitPackages(resolve, pkg_ids));
             }
@@ -572,7 +588,8 @@ impl WitOpts {
                     Ok(s) => s,
                     Err(_) => bail!("input was not valid utf-8"),
                 };
-                let mut resolve = WitResolve::resolve_with_features(&self.features);
+                let mut resolve =
+                    WitResolve::resolve_with_features(&self.features, self.all_features);
                 let pkgs = UnresolvedPackageGroup::parse(path, input)?;
                 let ids = resolve.append(pkgs)?;
                 Ok(DecodedWasm::WitPackages(resolve, ids))

tests/cli/wit-with-all-features.wit

@@ -0,0 +1,18 @@
+// RUN: component wit --all-features %
+
+package a:b;
+
+@unstable(feature = foo)
+interface foo {
+  @unstable(feature = foo)
+  type t = u32;
+}
+
+@unstable(feature = bar)
+interface bar {
+  @unstable(feature = baz)
+  use foo.{t};
+
+  @unstable(feature = qux)
+  record x { y: t }
+}

tests/cli/wit-with-all-features.wit.stdout

@@ -0,0 +1,20 @@
+/// RUN: component wit --all-features %
+package a:b;
+
+@unstable(feature = foo)
+interface foo {
+  @unstable(feature = foo)
+  type t = u32;
+}
+
+@unstable(feature = bar)
+interface bar {
+  @unstable(feature = baz)
+  use foo.{t};
+
+  @unstable(feature = qux)
+  record x {
+    y: t,
+  }
+}
+