wasm-encoder: fix encoding of f32 and f64 constant values in TryFrom<wasmparser::ConstExpr> (#1591)

12101111 · web-flow · commit 9340ed2466a5 · 2024-06-04T16:01:57.000Z
diff --git a/crates/wasm-encoder/src/core/code.rs b/crates/wasm-encoder/src/core/code.rs
@@ -3531,10 +3531,10 @@ impl<'a> TryFrom<wasmparser::ConstExpr<'a>> for ConstExpr {
             Some(Ok(wasmparser::Operator::I32Const { value })) => ConstExpr::i32_const(value),
             Some(Ok(wasmparser::Operator::I64Const { value })) => ConstExpr::i64_const(value),
             Some(Ok(wasmparser::Operator::F32Const { value })) => {
-                ConstExpr::f32_const(value.bits() as _)
+                ConstExpr::f32_const(f32::from_bits(value.bits()))
             }
             Some(Ok(wasmparser::Operator::F64Const { value })) => {
-                ConstExpr::f64_const(value.bits() as _)
+                ConstExpr::f64_const(f64::from_bits(value.bits()))
             }
             Some(Ok(wasmparser::Operator::V128Const { value })) => {
                 ConstExpr::v128_const(i128::from_le_bytes(*value.bytes()))

Original file line number	Diff line number	Diff line change
`@@ -3531,10 +3531,10 @@ impl<'a> TryFrom<wasmparser::ConstExpr<'a>> for ConstExpr {`
`3531`	`3531`	`Some(Ok(wasmparser::Operator::I32Const { value })) => ConstExpr::i32_const(value),`
`3532`	`3532`	`Some(Ok(wasmparser::Operator::I64Const { value })) => ConstExpr::i64_const(value),`
`3533`	`3533`	`Some(Ok(wasmparser::Operator::F32Const { value })) => {`
`3534`		`- ConstExpr::f32_const(value.bits() as _)`
	`3534`	`+ ConstExpr::f32_const(f32::from_bits(value.bits()))`
`3535`	`3535`	`}`
`3536`	`3536`	`Some(Ok(wasmparser::Operator::F64Const { value })) => {`
`3537`		`- ConstExpr::f64_const(value.bits() as _)`
	`3537`	`+ ConstExpr::f64_const(f64::from_bits(value.bits()))`
`3538`	`3538`	`}`
`3539`	`3539`	`Some(Ok(wasmparser::Operator::V128Const { value })) => {`
`3540`	`3540`	`ConstExpr::v128_const(i128::from_le_bytes(*value.bytes()))`