gen-host-js: make ComponentError string payload non-enumerable (#426)

Guy Bedford · web-flow · commit 6d48630ff2a7 · 2022-11-10T13:33:06.000-08:00
diff --git a/crates/gen-host-js/src/lib.rs b/crates/gen-host-js/src/lib.rs
@@ -555,9 +555,10 @@ impl Js {
 
             Intrinsic::ComponentError => self.src.js_intrinsics("
                 class ComponentError extends Error {
-                    constructor (payload) {
-                        super(payload);
-                        this.payload = payload;
+                    constructor (value) {
+                        const enumerable = typeof payload !== 'string';
+                        super(`${String(value)}${enumerable ? ' (see error.payload)' : ''}`);
+                        Object.defineProperty(this, 'payload', { value, enumerable });
                     }
                 }
             "),

Original file line number	Diff line number	Diff line change
`@@ -555,9 +555,10 @@ impl Js {`
`555`	`555`
`556`	`556`	`Intrinsic::ComponentError => self.src.js_intrinsics("`
`557`	`557`	`class ComponentError extends Error {`
`558`		`- constructor (payload) {`
`559`		`- super(payload);`
`560`		`- this.payload = payload;`
	`558`	`+ constructor (value) {`
	`559`	`+ const enumerable = typeof payload !== 'string';`
	`560`	+ super(`${String(value)}${enumerable ? ' (see error.payload)' : ''}`);
	`561`	`+ Object.defineProperty(this, 'payload', { value, enumerable });`
`561`	`562`	`}`
`562`	`563`	`}`
`563`	`564`	`"),`