Use buildifier to format bazel files. (#204)

Author: g-easy

WORKSPACE

@@ -33,18 +33,19 @@ http_archive(
 # Only needed for benchmarks, not to build the OpenCensus library.
 http_archive(
     name = "com_github_google_benchmark",
-    urls = ["https://github.com/google/benchmark/archive/master.zip"],
     strip_prefix = "benchmark-master",
+    urls = ["https://github.com/google/benchmark/archive/master.zip"],
 )
 
 # gRPC
 http_archive(
     name = "com_github_grpc_grpc",
+    strip_prefix = "grpc-master",
     urls = ["https://github.com/grpc/grpc/archive/master.tar.gz"],
-    strip_prefix = "grpc-master"
 )
 
 load("@com_github_grpc_grpc//bazel:grpc_deps.bzl", "grpc_deps")
+
 grpc_deps()
 
 # These bind()s are needed for the cc_grpc_library() rule to work.
@@ -73,10 +74,8 @@ load_civetweb()
 # Curl library - used by zipkin exporter.
 new_http_archive(
     name = "com_github_curl",
-    urls = ["https://github.com/curl/curl/archive/master.zip"],
-    strip_prefix = "curl-master",
     build_file_content =
-"""
+        """
 load("@io_opencensus_cpp//opencensus:curl.bzl", "CURL_COPTS")
 package(features = ['no_copts_tokenization'])
 
@@ -108,16 +107,16 @@ cc_library(
     ],
     visibility = ["//visibility:public"],
 )
-"""
+""",
+    strip_prefix = "curl-master",
+    urls = ["https://github.com/curl/curl/archive/master.zip"],
 )
 
 # Rapidjson library - used by zipkin exporter.
 new_http_archive(
     name = "com_github_rapidjson",
-    urls = ["https://github.com/Tencent/rapidjson/archive/master.zip"],
-    strip_prefix = "rapidjson-master",
     build_file_content =
-"""
+        """
 cc_library(
     name = "rapidjson",
     srcs = [],
@@ -130,5 +129,7 @@ cc_library(
     defines = ["RAPIDJSON_HAS_STDSTRING=1",],
     visibility = ["//visibility:public"],
 )
-"""
+""",
+    strip_prefix = "rapidjson-master",
+    urls = ["https://github.com/Tencent/rapidjson/archive/master.zip"],
 )

opencensus/curl.bzl

@@ -17,7 +17,6 @@
 BASE_CURL_COPTS = [
     # Disable everything else except HTTP protocol.
     "-DHTTP_ONLY=1",
-
     "-DENABLE_IPV6=1",
     "-DGETHOSTNAME_TYPE_ARG2=size_t",
     "-DGETSERVBYPORT_R_ARGS=6",

opencensus/exporters/trace/zipkin/BUILD

@@ -32,11 +32,11 @@ cc_library(
     copts = DEFAULT_COPTS,
     deps = [
         "//opencensus/trace",
+        "@com_github_curl//:curl",
+        "@com_github_rapidjson//:rapidjson",
         "@com_google_absl//absl/base:core_headers",
         "@com_google_absl//absl/memory",
         "@com_google_absl//absl/strings",
-        "@com_github_curl//:curl",
-        "@com_github_rapidjson//:rapidjson",
     ],
 )
 

opencensus/stats/BUILD

@@ -241,9 +241,9 @@ cc_binary(
     deps = [
         ":core",
         ":recording",
+        "@com_github_google_benchmark//:benchmark",
         "@com_google_absl//absl/memory",
         "@com_google_absl//absl/strings",
         "@com_google_absl//absl/time",
-        "@com_github_google_benchmark//:benchmark",
     ],
 )

opencensus/tags/BUILD

@@ -23,13 +23,13 @@ package(default_visibility = ["//visibility:private"])
 # The public tags API.
 cc_library(
     name = "tags",
-    hdrs = [
-      "tag_map.h",
-      "tag_key.h",
-    ],
     srcs = [
-      "internal/tag_key.cc",
-      "internal/tag_map.cc",
+        "internal/tag_key.cc",
+        "internal/tag_map.cc",
+    ],
+    hdrs = [
+        "tag_key.h",
+        "tag_map.h",
     ],
     copts = DEFAULT_COPTS,
     visibility = ["//visibility:public"],

opencensus/trace/BUILD

@@ -81,14 +81,14 @@ cc_library(
     copts = DEFAULT_COPTS,
     visibility = ["//visibility:public"],
     deps = [
+        "//opencensus/common/internal:random_lib",
         "@com_google_absl//absl/base:core_headers",
         "@com_google_absl//absl/base:endian",
         "@com_google_absl//absl/memory",
         "@com_google_absl//absl/strings",
         "@com_google_absl//absl/synchronization",
         "@com_google_absl//absl/time",
         "@com_google_absl//absl/types:span",
-        "//opencensus/common/internal:random_lib",
     ],
 )
 

opencensus/trace/examples/BUILD

@@ -31,9 +31,9 @@ cc_test(
     srcs = ["span_example.cc"],
     copts = TEST_COPTS,
     deps = [
+        "//opencensus/trace",
         "@com_google_absl//absl/memory",
         "@com_google_absl//absl/strings",
-        "//opencensus/trace",
         "@com_google_googletest//:gtest_main",
     ],
 )

tools/format.sh

@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-# Formats code under opencensus/, exits with 0 if there were no changes.
+# Formats code, exits with 0 if there were no changes.
 if [[ ! -e tools/format.sh ]]; then
   echo "This tool must be run from the topmost OpenCensus directory." >&2
   exit 1
@@ -28,6 +28,13 @@ sed -i 's/ \+$//' $(find * -type f)
 CMD=clang-format
 $CMD -version
 $CMD -i -style=Google $(find . -name '*.cc' -or -name '*.h')
+if which buildifier >/dev/null; then
+  echo "Running buildifier."
+  buildifier WORKSPACE $(find . -name BUILD -o -name \*.bzl)
+else
+  echo "Can't find buildifier. It can be installed with:"
+  echo "  go get github.com/bazelbuild/buildtools/buildifier"
+fi
 CHANGED="$(git ls-files --modified)"
 if [[ ! -z "$CHANGED" ]]; then
   echo "The following files have changes:"