Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Commit 21ff1f2

Browse files
authored
Cleanup: break up "responses" into status vs context. (#190)
No functional change.
1 parent cc57869 commit 21ff1f2

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

opencensus/exporters/stats/stackdriver/internal/stackdriver_exporter.cc

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ void Handler::ExportViewData(
9494
const int num_rpcs =
9595
ceil(static_cast<double>(time_series.size()) / kTimeSeriesBatchSize);
9696

97-
std::vector<std::pair<grpc::Status, ::grpc::ClientContext>> responses(
98-
num_rpcs);
97+
std::vector<grpc::Status> status(num_rpcs);
98+
std::vector<grpc::ClientContext> ctx(num_rpcs);
9999
// We can safely re-use an empty response--it is never updated.
100100
google::protobuf::Empty response;
101101
grpc::CompletionQueue cq;
@@ -108,23 +108,21 @@ void Handler::ExportViewData(
108108
for (int i = rpc_index * kTimeSeriesBatchSize; i < batch_end; ++i) {
109109
*request.add_time_series() = time_series[i];
110110
};
111-
responses[rpc_index].second.set_deadline(
111+
ctx[rpc_index].set_deadline(
112112
absl::ToChronoTime(absl::Now() + opts_.rpc_deadline));
113-
auto rpc(stub_->AsyncCreateTimeSeries(&responses[rpc_index].second, request,
114-
&cq));
115-
rpc->Finish(&response, &responses[rpc_index].first,
116-
(void*)(uintptr_t)rpc_index);
113+
auto rpc(stub_->AsyncCreateTimeSeries(&ctx[rpc_index], request, &cq));
114+
rpc->Finish(&response, &status[rpc_index], (void*)(uintptr_t)rpc_index);
117115
}
118116

119117
cq.Shutdown();
120118
void* tag;
121119
bool ok;
122120
while (cq.Next(&tag, &ok)) {
123121
if (ok) {
124-
const auto& status = responses[(uintptr_t)tag].first;
125-
if (!status.ok()) {
122+
const auto& s = status[(uintptr_t)tag];
123+
if (!s.ok()) {
126124
std::cerr << "CreateTimeSeries request failed: "
127-
<< opencensus::common::ToString(status) << "\n";
125+
<< opencensus::common::ToString(s) << "\n";
128126
}
129127
}
130128
}

0 commit comments

Comments
 (0)