Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Commit 87fc6a4

Browse files
author
Ian Sturdy
authored
Change Stackdriver units to "1" for count views. (#134)
1 parent f6aca42 commit 87fc6a4

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

opencensus/exporters/stats/stackdriver/internal/stackdriver_utils.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,10 @@ void SetMetricDescriptor(
160160
}
161161
metric_descriptor->set_metric_kind(google::api::MetricDescriptor::CUMULATIVE);
162162
metric_descriptor->set_value_type(GetValueType(view_descriptor));
163-
metric_descriptor->set_unit(view_descriptor.measure_descriptor().units());
163+
metric_descriptor->set_unit(
164+
view_descriptor.aggregation() == opencensus::stats::Aggregation::Count()
165+
? "1"
166+
: view_descriptor.measure_descriptor().units());
164167
metric_descriptor->set_description(view_descriptor.description());
165168
}
166169

opencensus/exporters/stats/stackdriver/internal/stackdriver_utils_test.cc

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,18 @@ TEST(StackdriverUtilsTest, SetMetricDescriptorUnits) {
133133
EXPECT_EQ(units, metric_descriptor.unit());
134134
}
135135

136+
TEST(StackdriverUtilsTest, SetMetricDescriptorUnitsCount) {
137+
opencensus::stats::MeasureDouble::Register("measure", "", "test_units");
138+
const auto view_descriptor =
139+
opencensus::stats::ViewDescriptor()
140+
.set_measure("measure")
141+
.set_aggregation(opencensus::stats::Aggregation::Count());
142+
google::api::MetricDescriptor metric_descriptor;
143+
SetMetricDescriptor("", view_descriptor, &metric_descriptor);
144+
145+
EXPECT_EQ("1", metric_descriptor.unit());
146+
}
147+
136148
TEST(StackdriverUtilsTest, SetMetricDescriptorDescription) {
137149
const std::string description = "test description";
138150
const auto view_descriptor =

0 commit comments

Comments
 (0)