Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Commit 8d26a64

Browse files
authored
Make default Stackdriver exporter deadlines match opencensus-java. (#388)
Also improve logging when exporter RPCs fail.
1 parent dec85ad commit 8d26a64

4 files changed

Lines changed: 13 additions & 8 deletions

File tree

opencensus/exporters/stats/stackdriver/internal/stackdriver_exporter.cc

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,11 @@ void Handler::ExportViewData(
145145
if (ok) {
146146
const auto& s = status[(uintptr_t)tag];
147147
if (!s.ok()) {
148-
std::cerr << "CreateTimeSeries request failed: "
149-
<< opencensus::common::ToString(s) << "\n";
148+
std::cerr << "CreateTimeSeries request failed (" << num_rpcs
149+
<< " RPCs, " << data.size() << " views, "
150+
<< time_series.size()
151+
<< " timeseries): " << opencensus::common::ToString(s)
152+
<< "\n";
150153
}
151154
}
152155
}
@@ -181,8 +184,9 @@ bool Handler::MaybeRegisterView(
181184
::grpc::Status status = opts_.metric_service_stub->CreateMetricDescriptor(
182185
&context, request, &response);
183186
if (!status.ok()) {
184-
std::cerr << "CreateMetricDescriptor request failed: "
185-
<< opencensus::common::ToString(status) << "\n";
187+
std::cerr << "CreateMetricDescriptor(" << request.metric_descriptor().name()
188+
<< ") request failed: " << opencensus::common::ToString(status)
189+
<< "\n";
186190
return false;
187191
}
188192
registered_descriptors_.emplace_hint(it, descriptor.name(), descriptor);

opencensus/exporters/stats/stackdriver/stackdriver_exporter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ struct StackdriverOptions {
3939
std::string opencensus_task;
4040

4141
// The RPC deadline to use when exporting to Stackdriver.
42-
absl::Duration rpc_deadline = absl::Seconds(5);
42+
absl::Duration rpc_deadline = absl::Seconds(60);
4343

4444
// Optional: the Stackdriver MonitoredResource to use.
4545
//

opencensus/exporters/trace/stackdriver/internal/stackdriver_exporter.cc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,8 +259,9 @@ void Handler::Export(
259259
grpc::Status status =
260260
opts_.trace_service_stub->BatchWriteSpans(&context, request, &response);
261261
if (!status.ok()) {
262-
std::cerr << "BatchWriteSpans failed: "
263-
<< opencensus::common::ToString(status) << "\n";
262+
std::cerr << "BatchWriteSpans failed (" << spans.size() << " spans, "
263+
<< request.ByteSizeLong()
264+
<< " bytes): " << opencensus::common::ToString(status) << "\n";
264265
}
265266
}
266267

opencensus/exporters/trace/stackdriver/stackdriver_exporter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ struct StackdriverOptions {
3232
std::string project_id;
3333

3434
// The RPC deadline to use when exporting to Stackdriver.
35-
absl::Duration rpc_deadline = absl::Seconds(5);
35+
absl::Duration rpc_deadline = absl::Seconds(10);
3636

3737
// (optional) By default, the exporter connects to Stackdriver using gRPC. If
3838
// this stub is non-null, the exporter will use this stub to send gRPC calls

0 commit comments

Comments
 (0)