Use the same copts as ABSL. (#11)

In particular, -Wno-sign-compare as Google style does not use unsigned
integers.

Author: g-easy

opencensus/BUILD

@@ -0,0 +1,23 @@
+# Copyright 2018, OpenCensus Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+licenses(["notice"])  # Apache 2.0
+
+config_setting(
+    name = "llvm_compiler",
+    values = {
+        "compiler": "llvm",
+    },
+    visibility = [":__subpackages__"],
+)

opencensus/common/internal/BUILD

@@ -14,13 +14,16 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("//opencensus:copts.bzl", "DEFAULT_COPTS", "TEST_COPTS")
+
 licenses(["notice"])  # Apache 2.0
 
 package(default_visibility = ["//opencensus:__subpackages__"])
 
 cc_library(
     name = "random_lib",
     srcs = ["random.cc"],
+    copts = DEFAULT_COPTS,
     hdrs = ["random.h"],
     deps = [
         "@com_google_absl//absl/synchronization",
@@ -31,6 +34,7 @@ cc_library(
 cc_library(
     name = "stats_object",
     hdrs = ["stats_object.h"],
+    copts = DEFAULT_COPTS,
     deps = [
         "@com_google_absl//absl/base:core_headers",
         "@com_google_absl//absl/memory",
@@ -43,6 +47,7 @@ cc_library(
 cc_library(
     name = "string_vector_hash",
     hdrs = ["string_vector_hash.h"],
+    copts = DEFAULT_COPTS,
 )
 
 # Tests
@@ -51,6 +56,7 @@ cc_library(
 cc_test(
     name = "random_test",
     srcs = ["random_test.cc"],
+    copts = TEST_COPTS,
     deps = [
         ":random_lib",
         "@com_google_googletest//:gtest_main",
@@ -61,6 +67,7 @@ cc_binary(
     name = "random_benchmark",
     testonly = 1,
     srcs = ["random_benchmark.cc"],
+    copts = TEST_COPTS,
     linkopts = ["-pthread"],  # Required for absl/synchronization bits.
     linkstatic = 1,
     deps = [
@@ -72,6 +79,7 @@ cc_binary(
 cc_test(
     name = "stats_object_test",
     srcs = ["stats_object_test.cc"],
+    copts = TEST_COPTS,
     deps = [
         ":stats_object",
         "@com_google_absl//absl/strings",

opencensus/copts.bzl

@@ -0,0 +1,40 @@
+# Copyright 2018, OpenCensus Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Compiler options for OpenCensus.
+
+Flags specified here must not impact ABI. Code compiled with and without these
+opts will be linked together, and in some cases headers compiled with and
+without these options will be part of the same program.
+
+We use the same flags as absl.
+"""
+
+load(
+    "@com_google_absl//absl:copts.bzl",
+    "GCC_FLAGS",
+    "GCC_TEST_FLAGS",
+    "LLVM_FLAGS",
+    "LLVM_TEST_FLAGS",
+)
+
+DEFAULT_COPTS = select({
+    "//opencensus:llvm_compiler": LLVM_FLAGS,
+    "//conditions:default": GCC_FLAGS,
+})
+
+TEST_COPTS = DEFAULT_COPTS + select({
+    "//opencensus:llvm_compiler": LLVM_TEST_FLAGS,
+    "//conditions:default": GCC_TEST_FLAGS,
+})

opencensus/stats/BUILD

@@ -14,6 +14,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("//opencensus:copts.bzl", "DEFAULT_COPTS", "TEST_COPTS")
+
 licenses(["notice"])  # Apache License 2.0
 
 package(default_visibility = ["//visibility:private"])
@@ -22,6 +24,7 @@ package(default_visibility = ["//visibility:private"])
 cc_library(
     name = "stats",
     hdrs = ["stats.h"],
+    copts = DEFAULT_COPTS,
     visibility = ["//visibility:public"],
     deps = [
         ":core",
@@ -36,6 +39,7 @@ cc_library(
     testonly = 1,
     srcs = ["testing/test_utils.cc"],
     hdrs = ["testing/test_utils.h"],
+    copts = DEFAULT_COPTS,
     visibility = ["//visibility:public"],
     deps = [
         ":core",
@@ -74,6 +78,7 @@ cc_library(
         "view_data.h",
         "view_descriptor.h",
     ],
+    copts = DEFAULT_COPTS,
     deps = [
         "@com_google_absl//absl/base:core_headers",
         "@com_google_absl//absl/memory",
@@ -91,6 +96,7 @@ cc_library(
     name = "recording",
     srcs = ["internal/recording.cc"],
     hdrs = ["recording.h"],
+    copts = DEFAULT_COPTS,
     deps = [
         ":core",
         "@com_google_absl//absl/strings",
@@ -107,6 +113,7 @@ cc_library(
         "stats_exporter.h",
         "view.h",
     ],
+    copts = DEFAULT_COPTS,
     deps = [
         ":core",
         "@com_google_absl//absl/base:core_headers",
@@ -123,6 +130,7 @@ cc_library(
 cc_test(
     name = "debug_string_test",
     srcs = ["internal/debug_string_test.cc"],
+    copts = TEST_COPTS,
     deps = [
         ":core",
         "@com_google_absl//absl/time",
@@ -133,6 +141,7 @@ cc_test(
 cc_test(
     name = "distribution_test",
     srcs = ["internal/distribution_test.cc"],
+    copts = TEST_COPTS,
     deps = [
         ":core",
         "@com_google_googletest//:gtest_main",
@@ -142,6 +151,7 @@ cc_test(
 cc_test(
     name = "bucket_boundaries_test",
     srcs = ["internal/bucket_boundaries_test.cc"],
+    copts = TEST_COPTS,
     deps = [
         ":core",
         "@com_google_googletest//:gtest_main",
@@ -151,6 +161,7 @@ cc_test(
 cc_test(
     name = "measure_registry_test",
     srcs = ["internal/measure_registry_test.cc"],
+    copts = TEST_COPTS,
     deps = [
         ":core",
         "@com_google_absl//absl/strings",
@@ -161,6 +172,7 @@ cc_test(
 cc_test(
     name = "stats_exporter_test",
     srcs = ["internal/stats_exporter_test.cc"],
+    copts = TEST_COPTS,
     deps = [
         ":core",
         ":export",
@@ -173,6 +185,7 @@ cc_test(
 cc_test(
     name = "stats_manager_test",
     srcs = ["internal/stats_manager_test.cc"],
+    copts = TEST_COPTS,
     deps = [
         ":core",
         ":export",
@@ -185,6 +198,7 @@ cc_test(
 cc_test(
     name = "view_data_impl_test",
     srcs = ["internal/view_data_impl_test.cc"],
+    copts = TEST_COPTS,
     deps = [
         ":core",
         "@com_google_absl//absl/time",

opencensus/stats/examples/BUILD

@@ -14,6 +14,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+load("//opencensus:copts.bzl", "TEST_COPTS")
+
 licenses(["notice"])  # Apache 2.0
 
 package(
@@ -27,6 +29,7 @@ package(
 cc_test(
     name = "view_and_recording_example",
     srcs = ["view_and_recording_example.cc"],
+    copts = TEST_COPTS,
     deps = [
         "//opencensus/stats",
         "@com_google_googletest//:gtest_main",
@@ -36,6 +39,7 @@ cc_test(
 cc_test(
     name = "exporter_example",
     srcs = ["exporter_example.cc"],
+    copts = TEST_COPTS,
     deps = [
         "@com_google_absl//absl/memory",
         "@com_google_absl//absl/strings",

opencensus/stats/measure_descriptor.h

@@ -36,7 +36,7 @@ class MeasureDescriptor final {
   const std::string& name() const { return name_; }
   const std::string& units() const { return units_; }
   const std::string& description() const { return description_; }
-  const Type type() const { return type_; }
+  Type type() const { return type_; }
 
   std::string DebugString() const;