support double attribute (#44)

* support double attribute values

* added double value

Author: SergeyKanzhelev

CHANGELOG.md

@@ -1,5 +1,6 @@
 # Unreleased
 
+- Support double attributes according to the [spec change](https://github.com/census-instrumentation/opencensus-specs/issues/172).
 - Initial implementation of Prometheus exporter.
 - Initial version of Application Insights exporter implemented.
 - Zipkin exporter implemented.

src/OpenCensus.Abstractions/Trace/IAttributeValue.cs

@@ -24,6 +24,7 @@ T Match<T>(
              Func<string, T> stringFunction,
              Func<bool, T> booleanFunction,
              Func<long, T> longFunction,
+             Func<double, T> doubleFunction,
              Func<object, T> defaultFunction);
     }
 

src/OpenCensus.Exporter.ApplicationInsights/Implementation/TraceExporterHandler.cs

@@ -65,6 +65,7 @@ public void Export(IList<ISpanData> spanDataList)
                         (s) => { return s; },
                         (b) => { return b.ToString(); },
                         (l) => { return l.ToString(); },
+                        (d) => { return d.ToString(); },
                         (obj) => { return obj.ToString(); });
 
                     result.Properties.Add(attr.Key, value);
@@ -99,6 +100,10 @@ private bool IsClientSpanKind(IAttributeValue value)
                     return false;
                 },
                 (arg) =>
+                {
+                    return false;
+                },
+                (arg) =>
                 {
                     return false;
                 });
@@ -120,6 +125,10 @@ private bool IsServerSpanKind(IAttributeValue value)
                     return false;
                 },
                 (arg) =>
+                {
+                    return false;
+                },
+                (arg) =>
                 {
                     return false;
                 });

src/OpenCensus.Exporter.Zipkin/Implementation/TraceExporterHandler.cs

@@ -124,6 +124,7 @@ private string AttributeValueToString(IAttributeValue attributeValue)
                 (arg) => { return arg; },
                 (arg) => { return arg.ToString(); },
                 (arg) => { return arg.ToString(); },
+                (arg) => { return arg.ToString(); },
                 (arg) => { return null; });
         }
 
@@ -186,6 +187,10 @@ private bool IsClientSpanKind(IAttributeValue value)
                     return false;
                 },
                 (arg) =>
+                {
+                    return false;
+                },
+                (arg) =>
                 {
                     return false;
                 });
@@ -207,6 +212,10 @@ private bool IsServerSpanKind(IAttributeValue value)
                     return false;
                 },
                 (arg) =>
+                {
+                    return false;
+                },
+                (arg) =>
                 {
                     return false;
                 });

src/OpenCensus/Trace/AttributeValue.cs

@@ -44,10 +44,16 @@ public static IAttributeValue<bool> BooleanAttributeValue(bool booleanValue)
             return new AttributeValue<bool>(booleanValue);
         }
 
+        public static IAttributeValue<double> DoubleAttributeValue(double doubleValue)
+        {
+            return new AttributeValue<double>(doubleValue);
+        }
+
         public abstract T Match<T>(
             Func<string, T> stringFunction,
             Func<bool, T> booleanFunction,
             Func<long, T> longFunction,
+            Func<double, T> doubleFunction,
             Func<object, T> defaultFunction);
     }
 }

src/OpenCensus/Trace/AttributeValue{T}.cs

@@ -47,6 +47,11 @@ public static IAttributeValue<bool> Create(bool booleanValue)
             return new AttributeValue<bool>(booleanValue);
         }
 
+        public static IAttributeValue<double> Create(double doubleValue)
+        {
+            return new AttributeValue<double>(doubleValue);
+        }
+
         public TArg Apply<TArg>(Func<T, TArg> function)
         {
             return function(this.Value);
@@ -89,25 +94,29 @@ public override TReturn Match<TReturn>(
             Func<string, TReturn> stringFunction,
             Func<bool, TReturn> booleanFunction,
             Func<long, TReturn> longFunction,
+            Func<double, TReturn> doubleFunction,
             Func<object, TReturn> defaultFunction)
         {
             if (typeof(T) == typeof(string))
             {
                 string value = this.Value as string;
                 return stringFunction(value);
-            }
-
-            if (typeof(T) == typeof(long))
+            } 
+            else if (typeof(T) == typeof(long))
             {
                 long val = (long)(object)this.Value;
                 return longFunction(val);
             }
-
-            if (typeof(T) == typeof(bool))
+            else if (typeof(T) == typeof(bool))
             {
                 bool val = (bool)(object)this.Value;
                 return booleanFunction(val);
             }
+            else if (typeof(T) == typeof(double))
+            {
+                double val = (double)(object)this.Value;
+                return doubleFunction(val);
+            }
 
             return defaultFunction(this.Value);
         }

test/OpenCensus.Tests/Impl/Trace/AttributeValueTest.cs

@@ -54,22 +54,15 @@ public void LongAttributeValue()
             });
         }
 
-
         [Fact]
-        public void AttributeValue_EqualsAndHashCode()
+        public void DoubleAttributeValue()
         {
-            // EqualsTester tester = new EqualsTester();
-            // tester.addEqualityGroup(
-            //    AttributeValue.stringAttributeValue("MyStringAttributeValue"),
-            //    AttributeValue.stringAttributeValue("MyStringAttributeValue"));
-            // tester.addEqualityGroup(AttributeValue.stringAttributeValue("MyStringAttributeDiffValue"));
-            // tester.addEqualityGroup(
-            //    AttributeValue.booleanAttributeValue(true), AttributeValue.booleanAttributeValue(true));
-            // tester.addEqualityGroup(AttributeValue.booleanAttributeValue(false));
-            // tester.addEqualityGroup(
-            //    AttributeValue.longAttributeValue(123456L), AttributeValue.longAttributeValue(123456L));
-            // tester.addEqualityGroup(AttributeValue.longAttributeValue(1234567L));
-            // tester.testEquals();
+            var attribute = AttributeValue<double>.Create(0.005);
+            attribute.Apply<object>((val) =>
+            {
+                Assert.Equal(0.005, val);
+                return null;
+            });
         }
 
         [Fact]

test/OpenCensus.Tests/Impl/Trace/BlankSpanTest.cs

@@ -39,6 +39,7 @@ public void DoNotCrash()
                 "MyStringAttributeKey", AttributeValue<string>.Create("MyStringAttributeValue"));
             multipleAttributes.Add("MyBooleanAttributeKey", AttributeValue<bool>.Create(true));
             multipleAttributes.Add("MyLongAttributeKey", AttributeValue<long>.Create(123));
+            multipleAttributes.Add("MyDoubleAttributeKey", AttributeValue<double>.Create(0.005));
             // Tests only that all the methods are not crashing/throwing errors.
             BlankSpan.Instance.PutAttribute(
                 "MyStringAttributeKey2", AttributeValue<string>.Create("MyStringAttributeValue2"));

test/OpenCensus.Tests/Impl/Trace/LinkTest.cs

@@ -34,6 +34,7 @@ public LinkTest()
             attributesMap.Add("MyAttributeKey0", AttributeValue<string>.Create("MyStringAttribute"));
             attributesMap.Add("MyAttributeKey1", AttributeValue<long>.Create(10));
             attributesMap.Add("MyAttributeKey2", AttributeValue<bool>.Create(true));
+            attributesMap.Add("MyAttributeKey3", AttributeValue<double>.Create(0.005));
         }
 
         [Fact]