Few more warning fix (#37)

* fix few more warnings

* few more

Author: SergeyKanzhelev

.vsts/ci-myget-update.yml

@@ -1,5 +1,11 @@
 # CI build with the upload to MyGet
 
+trigger:
+  branches:
+    include:
+    - master
+    - develop
+
 queue: Hosted VS2017
 steps:
 - task: DotNetCoreInstaller@0

src/OpenCensus.Exporter.Zipkin/Implementation/TraceExporterHandler.cs

@@ -274,7 +274,7 @@ private ZipkinEndpoint GetLocalZipkinEndpoint()
         {
             var result = new ZipkinEndpoint()
             {
-                ServiceName = this.options.ServiceName
+                ServiceName = this.options.ServiceName,
             };
 
             string hostName = this.ResolveHostName();

src/OpenCensus.Exporter.Zipkin/Implementation/ZipkinSpanKind.cs

@@ -36,6 +36,6 @@ internal enum ZipkinSpanKind
         /// <summary>
         /// Consumer.
         /// </summary>
-        CONSUMER
+        CONSUMER,
     }
 }

src/OpenCensus.Exporter.Zipkin/OpenCensus.Exporter.Zipkin.csproj

@@ -21,7 +21,7 @@
 
   <ItemGroup>
     <ProjectReference Include="..\OpenCensus\OpenCensus.csproj" />
-    <PackageReference Include="StyleCop.Analyzers" Version="1.0.2">
+    <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta008">
       <PrivateAssets>All</PrivateAssets>
     </PackageReference>
     <PackageReference Include="Newtonsoft.Json" Version="11.0.2" />

src/OpenCensus.Exporter.Zipkin/ZipkinTraceExporter.cs

@@ -44,7 +44,7 @@ public class ZipkinTraceExporter
         /// <param name="exportComponent">Exporter to get traces from.</param>
         /// <param name="client">Http client to use to upload telemetry.
         /// For local development with invalid certificates use code like this: 
-        /// new HttpClient(new HttpClientHandler() { ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator })
+        /// new HttpClient(new HttpClientHandler() { ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator }).
         /// </param>
         public ZipkinTraceExporter(ZipkinTraceExporterOptions options, IExportComponent exportComponent, HttpClient client = null)
         {

…OpenCensus/Api/Stats/IBucketBoundries.cs …penCensus/Api/Stats/IBucketBoundaries.cssrc/OpenCensus/Api/Stats/IBucketBoundries.cs renamed to src/OpenCensus/Api/Stats/IBucketBoundaries.cs src/OpenCensus/Api/Stats/IBucketBoundries.cs renamed to src/OpenCensus/Api/Stats/IBucketBoundaries.cs

@@ -1,4 +1,4 @@
-// <copyright file="IBucketBoundries.cs" company="OpenCensus Authors">
+// <copyright file="IBucketBoundaries.cs" company="OpenCensus Authors">
 // Copyright 2018, OpenCensus Authors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");

src/OpenCensus/Api/Stats/StatsCollectionState.cs

@@ -19,6 +19,6 @@ namespace OpenCensus.Stats
     public enum StatsCollectionState
     {
         ENABLED,
-        DISABLED
+        DISABLED,
     }
 }

src/OpenCensus/Impl/Common/DateTimeOffsetClock.cs

@@ -20,24 +20,19 @@ namespace OpenCensus.Common
 
     internal class DateTimeOffsetClock : IClock
     {
-        internal const long MILLIS_PER_SECOND = 1000L;
-        internal const long NANOS_PER_MILLI = 1000 * 1000;
-        internal const long NANOS_PER_SECOND = NANOS_PER_MILLI * MILLIS_PER_SECOND;
+        public static readonly DateTimeOffsetClock Instance = new DateTimeOffsetClock();
 
-        public static readonly DateTimeOffsetClock INSTANCE = new DateTimeOffsetClock();
-
-        public static IClock GetInstance()
-        {
-            return INSTANCE;
-        }
+        internal const long MillisPerSecond = 1000L;
+        internal const long NanosPerMilli = 1000 * 1000;
+        internal const long NanosPerSecond = NanosPerMilli * MillisPerSecond;
 
         public ITimestamp Now
         {
             get
             {
                 var nowNanoTicks = this.NowNanos;
-                var nowSecTicks = nowNanoTicks / NANOS_PER_SECOND;
-                var excessNanos = nowNanoTicks - (nowSecTicks * NANOS_PER_SECOND);
+                var nowSecTicks = nowNanoTicks / NanosPerSecond;
+                var excessNanos = nowNanoTicks - (nowSecTicks * NanosPerSecond);
                 return new Timestamp(nowSecTicks, (int)excessNanos);
             }
         }
@@ -47,8 +42,13 @@ public long NowNanos
             get
             {
                 var millis = DateTimeOffset.UtcNow.ToUnixTimeMilliseconds();
-                return millis * NANOS_PER_MILLI;
+                return millis * NanosPerMilli;
             }
         }
+
+        public static IClock GetInstance()
+        {
+            return Instance;
+        }
     }
 }

src/OpenCensus/Impl/Common/ZeroTimeClock.cs

@@ -18,14 +18,14 @@ namespace OpenCensus.Common
 {
     internal sealed class ZeroTimeClock : IClock
     {
-        public static readonly ZeroTimeClock INSTANCE = new ZeroTimeClock();
-        private static readonly ITimestamp ZERO_TIMESTAMP = Timestamp.Create(0, 0);
+        public static readonly ZeroTimeClock Instance = new ZeroTimeClock();
+        private static readonly ITimestamp ZeroTimestamp = Timestamp.Create(0, 0);
 
         public ITimestamp Now
         {
             get
             {
-                return ZERO_TIMESTAMP;
+                return ZeroTimestamp;
             }
         }
 

src/OpenCensus/Impl/Internal/NoopScope.cs

@@ -20,20 +20,20 @@ namespace OpenCensus.Internal
 
     public sealed class NoopScope : IScope
     {
-        public static readonly IScope INSTANCE = new NoopScope();
+        public static readonly IScope NoopInstance = new NoopScope();
+
+        private NoopScope()
+        {
+        }
 
         public static IScope Instance
         {
             get
             {
-                return INSTANCE;
+                return NoopInstance;
             }
         }
 
-        private NoopScope()
-        {
-        }
-
         public void Dispose()
         {
         }