Next iteration of cleaning APIs from IList (#94)

* links are IEnumerable

* added retry into flacky test

* no ILists in StackDriver

* removed comments

* fix running span storages

* few more fixes

* fix failed test

Author: SergeyKanzhelev

src/OpenCensus.Abstractions/Trace/Export/ILinks.cs

@@ -26,7 +26,7 @@ public interface ILinks
         /// <summary>
         /// Gets the list of links.
         /// </summary>
-        IList<ILink> Links { get; }
+        IEnumerable<ILink> Links { get; }
 
         /// <summary>
         /// Gets the number of dropped links due to exceeding the maximum links count limit.

src/OpenCensus.Abstractions/Trace/Export/IRunningSpanStore.cs

@@ -33,7 +33,7 @@ public interface IRunningSpanStore
         /// </summary>
         /// <param name="filter">Filter to apply to query running spans.</param>
         /// <returns>List of currently running spans.</returns>
-        IList<ISpanData> GetRunningSpans(IRunningSpanStoreFilter filter);
+        IEnumerable<ISpanData> GetRunningSpans(IRunningSpanStoreFilter filter);
 
         /// <summary>
         /// Called when span got started.

src/OpenCensus.Abstractions/Trace/Export/ISampledSpanStore.cs

@@ -38,14 +38,14 @@ public interface ISampledSpanStore
         /// </summary>
         /// <param name="filter">Filter to use to query sampled store.</param>
         /// <returns>List of spans satisfying filtering criteria.</returns>
-        IList<ISpanData> GetLatencySampledSpans(ISampledSpanStoreLatencyFilter filter);
+        IEnumerable<ISpanData> GetLatencySampledSpans(ISampledSpanStoreLatencyFilter filter);
 
         /// <summary>
         /// Gets the list of error spans using provided error filter.
         /// </summary>
         /// <param name="filter">Filter to use to query store.</param>
         /// <returns>List of sampled spans satisfying filtering criteria.</returns>
-        IList<ISpanData> GetErrorSampledSpans(ISampledSpanStoreErrorFilter filter);
+        IEnumerable<ISpanData> GetErrorSampledSpans(ISampledSpanStoreErrorFilter filter);
 
         /// <summary>
         /// Registers span names for collection.

src/OpenCensus.Abstractions/Trace/Export/ITimedEvents.cs

@@ -27,7 +27,7 @@ public interface ITimedEvents<T>
         /// <summary>
         /// Gets ths list of timed events.
         /// </summary>
-        IList<ITimedEvent<T>> Events { get; }
+        IEnumerable<ITimedEvent<T>> Events { get; }
 
         /// <summary>
         /// Gets the number of dropped events due to active limits.

src/OpenCensus.Exporter.Prometheus/Implementation/PrometheusMetricBuilder.cs

@@ -32,30 +32,30 @@ internal class PrometheusMetricBuilder
         {
             'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z',
             'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z',
-            '_', ':'
+            '_', ':',
         };
 
         private static char[] nameCharset = new char[]
         {
             'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z',
             'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z',
             '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-            '_', ':'
+            '_', ':',
         };
 
         private static char[] firstCharacterLabelCharset = new char[]
         {
             'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z',
             'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z',
-            '_'
+            '_',
         };
 
         private static char[] labelCharset = new char[]
         {
             'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z',
             'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z',
             '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
-            '_'
+            '_',
         };
 
         private readonly IList<PrometheusMetricValueBuilder> values = new List<PrometheusMetricValueBuilder>();

src/OpenCensus.Exporter.Stackdriver/Utils/CommonUtils.cs

@@ -26,17 +26,29 @@ namespace OpenCensus.Exporter.Stackdriver.Utils
     public static class CommonUtils
     {
         /// <summary>
-        /// Divide the source list into batches of lists of given size
+        /// Divide the source list into batches of lists of given size.
         /// </summary>
         /// <typeparam name="T">The type of the list</typeparam>
         /// <param name="source">The list</param>
         /// <param name="size">Size of the batch</param>
         /// <returns></returns>
-        public static IEnumerable<List<T>> Partition<T>(this IList<T> source, Int32 size)
+        public static IEnumerable<IEnumerable<T>> Partition<T>(this IEnumerable<T> source, int size)
         {
-            for (int i = 0; i < Math.Ceiling(source.Count / (double)size); i++)
+            using (var enumerator = source.GetEnumerator())
             {
-                yield return new List<T>(source.Skip(size * i).Take(size));
+                while (enumerator.MoveNext())
+                {
+                    yield return WalkPartition(enumerator, size - 1);
+                }
+            }
+        }
+
+        private static IEnumerable<T> WalkPartition<T>(IEnumerator<T> source, int size)
+        {
+            yield return source.Current;
+            for (int i = 0; i < size && source.MoveNext(); i++)
+            {
+                yield return source.Current;
             }
         }
     }

src/OpenCensus/Common/Duration.cs

@@ -72,7 +72,7 @@ public override string ToString()
                 + "}";
         }
 
-    /// <inheritdoc/>
+        /// <inheritdoc/>
         public override bool Equals(object o)
         {
             if (o == this)
@@ -89,7 +89,7 @@ public override bool Equals(object o)
             return false;
         }
 
-    /// <inheritdoc/>
+        /// <inheritdoc/>
         public override int GetHashCode()
         {
             long h = 1;

src/OpenCensus/Stats/CumulativeMutableViewData.cs

@@ -33,7 +33,7 @@ internal CumulativeMutableViewData(IView view, ITimestamp start)
 
         internal override void Record(ITagContext context, double value, ITimestamp timestamp)
         {
-            IList<ITagValue> values = GetTagValues(GetTagMap(context), this.View.Columns);
+            var values = GetTagValues(GetTagMap(context), this.View.Columns);
             var tagValues = TagValues.Create(values);
             if (!this.tagValueAggregationMap.ContainsKey(tagValues))
             {

src/OpenCensus/Stats/IntervalBucket.cs

@@ -22,7 +22,7 @@ namespace OpenCensus.Stats
 
     internal class MeasureMapBuilder
     {
-        private readonly IList<IMeasurement> measurements = new List<IMeasurement>();
+        private readonly List<IMeasurement> measurements = new List<IMeasurement>();
 
         internal static MeasureMapBuilder Builder()
         {