Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Commit 37d708e

Browse files
tsloughterdeadtrickster
authored andcommitted
rand:uniform is =< N so substract 1 from max span/trace id (#147)
Thanks to Erik Dahmen for reporting this
1 parent 5e697cd commit 37d708e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/opencensus.erl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
%%--------------------------------------------------------------------
6969
-spec generate_trace_id() -> trace_id().
7070
generate_trace_id() ->
71-
uniform(2 bsl 127). %% 2 shifted left by 127 == 2 ^ 128
71+
uniform(2 bsl 127 - 1). %% 2 shifted left by 127 == 2 ^ 128
7272

7373
%%--------------------------------------------------------------------
7474
%% @doc
@@ -77,7 +77,7 @@ generate_trace_id() ->
7777
%%--------------------------------------------------------------------
7878
-spec generate_span_id() -> span_id().
7979
generate_span_id() ->
80-
uniform(2 bsl 63). %% 2 shifted left by 63 == 2 ^ 64
80+
uniform(2 bsl 63 - 1). %% 2 shifted left by 63 == 2 ^ 64
8181

8282
%%--------------------------------------------------------------------
8383
%% @doc

0 commit comments

Comments
 (0)