Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Commit 2375b22

Browse files
iamgr0otsongy23
authored andcommitted
Recording http metrics at host level (#1926)
* Recording http metrics at host level * Always adding hsot * Revert "Always adding hsot" This reverts commit c02d008. * reverting back to default views
1 parent a9451b6 commit 2375b22

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

contrib/http_jaxrs/src/main/java/io/opencensus/contrib/http/jaxrs/JaxrsClientExtractor.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,13 @@ public String getUrl(ClientRequestContext request) {
4444
@Nullable
4545
@Override
4646
public String getHost(ClientRequestContext request) {
47-
return request.getUri().getHost();
47+
if (request == null) {
48+
return "null_request";
49+
} else if (request.getUri() == null) {
50+
return "null_uri";
51+
} else {
52+
return request.getUri().getHost();
53+
}
4854
}
4955

5056
@Nullable

contrib/http_util/src/main/java/io/opencensus/contrib/http/HttpClientHandler.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import static com.google.common.base.Preconditions.checkNotNull;
2020
import static io.opencensus.contrib.http.HttpRequestContext.METADATA_NO_PROPAGATION;
21+
import static io.opencensus.contrib.http.util.HttpMeasureConstants.HTTP_CLIENT_HOST;
2122
import static io.opencensus.contrib.http.util.HttpMeasureConstants.HTTP_CLIENT_METHOD;
2223
import static io.opencensus.contrib.http.util.HttpMeasureConstants.HTTP_CLIENT_RECEIVED_BYTES;
2324
import static io.opencensus.contrib.http.util.HttpMeasureConstants.HTTP_CLIENT_ROUNDTRIP_LATENCY;
@@ -156,9 +157,15 @@ private void recordStats(HttpRequestContext context, @Nullable Q request, int ht
156157
double requestLatency = NANOSECONDS.toMillis(System.nanoTime() - context.requestStartTime);
157158

158159
String methodStr = request == null ? "" : extractor.getMethod(request);
160+
String host = request == null ? "null_request" : extractor.getHost(request);
161+
159162
TagContext startCtx =
160163
tagger
161164
.toBuilder(context.tagContext)
165+
.put(
166+
HTTP_CLIENT_HOST,
167+
TagValue.create(host == null ? "null_host" : host),
168+
METADATA_NO_PROPAGATION)
162169
.put(
163170
HTTP_CLIENT_METHOD,
164171
TagValue.create(methodStr == null ? "" : methodStr),

0 commit comments

Comments
 (0)