Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Commit 282d742

Browse files
authored
Log error if Spans are gc-ed without being closed. (#1877)
* Log error if Spans are gc-ed without being closed. * Fix checkstyle. * Update log level.
1 parent 68e19ed commit 282d742

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

impl_core/src/main/java/io/opencensus/implcore/trace/RecordEventsSpanImpl.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -586,4 +586,15 @@ private RecordEventsSpanImpl(
586586
timestampConverter != null ? timestampConverter : TimestampConverter.now(clock);
587587
startNanoTime = clock.nowNanos();
588588
}
589+
590+
@SuppressWarnings("NoFinalizer")
591+
@Override
592+
protected void finalize() throws Throwable {
593+
synchronized (this) {
594+
if (!hasBeenEnded) {
595+
logger.log(Level.SEVERE, "Span " + name + " is GC'ed without being ended.");
596+
}
597+
}
598+
super.finalize();
599+
}
589600
}

0 commit comments

Comments
 (0)