feat: add config logger in start and unit test

Author: eldreygalindo

packages/opencensus-nodejs/src/trace/tracing.ts

@@ -23,12 +23,12 @@ import {Sampler} from '@opencensus/opencensus-core';
 import {Logger} from '@opencensus/opencensus-core';
 import {ConsoleExporter, Exporter, NoopExporter} from '@opencensus/opencensus-core';
 import {Config} from '@opencensus/opencensus-core';
-import * as extend from 'extend';
+import * as logger from '@opencensus/opencensus-core';
 
 import {defaultConfig} from './config/config';
 import {CONSTANTS} from './constants';
 import {PluginLoader} from './instrumentation/plugingloader';
-
+import * as extend from 'extend';
 
 /** Implements a Tracing. */
 export class TracingImpl implements Tracing {
@@ -69,13 +69,15 @@ export class TracingImpl implements Tracing {
     this.config = extend(
         true, {}, defaultConfig, {plugins: this.defaultPlugins}, userConfig);
     // TODO: Instance logger if no logger was passed
-    this.logger = this.config.logger;
+    this.logger = this.config.logger || logger.logger();
     debug('config: %o', this.config);
     this.pluginLoader.loadPlugins(this.config.plugins);
 
     if (!this.config.exporter) {
       const exporter = new ConsoleExporter(this.config);
       this.registerExporter(exporter);
+    }else{
+      this.registerExporter(this.config.exporter);
     }
     this.active = true;
     this.tracerLocal.start(this.config);

packages/opencensus-nodejs/test/test-tracing.ts

@@ -14,11 +14,22 @@
  * limitations under the License.
  */
 
-import {ConsoleExporter, Exporter, Tracer, TracerImpl, Tracing} from '@opencensus/opencensus-core';
-import * as assert from 'assert';
+import {ConsoleExporter} from '@opencensus/opencensus-core';
+import {Exporter} from '@opencensus/opencensus-core';
+import {Tracer} from '@opencensus/opencensus-core';
+import {TracerImpl} from '@opencensus/opencensus-core';
+import {Tracing} from '@opencensus/opencensus-core';
+import {Logger} from '@opencensus/opencensus-core';
+import {Config, TracingConfig} from '@opencensus/opencensus-core';
+import {NoopExporter} from '@opencensus/opencensus-core';
+
+import * as logger from '@opencensus/opencensus-core';
 
 import {TracingImpl} from '../src/trace/tracing';
+import * as assert from 'assert';
 
+
+const NOOP_EXPORTER = new NoopExporter();
 describe('Tracing', () => {
   /** Should create a Tracing instance */
   describe('new Tracing()', () => {
@@ -39,16 +50,30 @@ describe('Tracing', () => {
   /** Should return a started tracing instance */
   describe('start()', () => {
     let tracingStarted: Tracing;
-    before(() => {
-      const tracing = new TracingImpl();
-      tracingStarted = tracing.start();
-    });
+    const tracing = new TracingImpl();
+    // tslint:disable:no-any
+    function instanceOfLogger(object: any): object is Logger {
+      return 'debug' in object;
+    }
+
     it('should return a tracing instance', () => {
+      tracingStarted = tracing.start();
       assert.ok(tracingStarted instanceof TracingImpl);
     });
 
     it('the tracing was started', () => {
+      tracingStarted = tracing.start();
       assert.ok(tracingStarted.tracer.active);
+    });    
+    it('should tracing.tracer instance with logger', () =>{
+      
+      tracingStarted = tracing.start({logger:logger.logger('debug')});
+      assert.ok(instanceOfLogger(tracingStarted.tracer.logger));
+    });
+    it('should tracing.tracer instance with exporter', () =>{
+      
+      tracingStarted = tracing.start({exporter: NOOP_EXPORTER});
+      assert.equal(tracingStarted.exporter, NOOP_EXPORTER);
     });
   });