chord: merge commit

Author: djonathascardoso

packages/opencensus-core/src/trace/model/root-span.ts

@@ -18,7 +18,7 @@ import { Span } from './span'
 import { Clock } from '../../internal/clock'
 import * as uuid from 'uuid';
 import { debug } from '../../internal/util'
-import { SpanBaseModel, TraceContext, OnEndSpanEventListener } from '../types/tracetypes'
+import { SpanBaseModel, TraceContext, OnEndSpanEventListener, TraceOptions } from '../types/tracetypes'
 import { Tracer } from './tracer';
 
 export class RootSpan extends SpanBaseModel implements OnEndSpanEventListener {
@@ -27,10 +27,12 @@ export class RootSpan extends SpanBaseModel implements OnEndSpanEventListener {
     private _spans: Span[];
     private _traceId: string;
 
-    constructor(tracer: Tracer, context?: TraceContext ) {
+    //TODO - improve root name setup
+    constructor(tracer: Tracer, context?: TraceOptions ) {
         super()
         this.tracer = tracer;
-        this._traceId = context&&context.traceId?context.traceId:(uuid.v4().split('-').join(''));
+        this._traceId = context&&context.traceContext&&context.traceContext.traceId?context.traceContext.traceId:(uuid.v4().split('-').join(''));
+        this.name = context&&context.name?context.name:'undefined';
         this._spans = [];
     }
 
@@ -69,7 +71,7 @@ export class RootSpan extends SpanBaseModel implements OnEndSpanEventListener {
     }
 
     public onEndSpan(span: Span) {
-        debug('%s notified ending by %o',{id: span.id, name: span.name})
+        debug('ended span notified  %o', {id: span.id, name: span.name})
     }
 
     public startSpan(name: string, type: string) {

packages/opencensus-core/src/trace/model/tracer.ts

@@ -20,8 +20,8 @@ import { Span } from './span'
 import { debug } from '../../internal/util'
 import { Stackdriver } from '../../exporters/stackdriver/stackdriver'
 import { StackdriverOptions } from '../../exporters/stackdriver/options'
-import { TraceContext, OnEndSpanEventListener } from '../types/tracetypes';
-import { TracerConfig, defaultConfig } from '../tracing';
+import { TraceContext, TraceOptions, OnEndSpanEventListener } from '../types/tracetypes';
+import {  TracerConfig, defaultConfig } from '../tracing';
 
 export type Func<T> = (...args: any[]) => T;
 
@@ -66,36 +66,36 @@ export class Tracer implements OnEndSpanEventListener {
         return this._active;
     }
 
-    public startRootSpan(context?: TraceContext): RootSpan {
-        let newTrace = new RootSpan(this, context);
-        this.setCurrentRootSpan(newTrace);
-        newTrace.start();
-        return newTrace;
+    public startRootSpan<T>(options: TraceOptions, fn: (root: RootSpan) => T): T {
+        debug('starting root span: %o', options)
+        return this.contextManager.runAndReturn((root) => {
+            let newRoot = new RootSpan(this, options);
+            this.setCurrentRootSpan(newRoot);
+            newRoot.start();
+            return fn(newRoot);
+        });
     }
 
 
     public onEndSpan(root:RootSpan): void {
-        if (!this.currentRootSpan) {
+        if (!root) {
             return debug('cannot end trace - no active trace found')
         }
         if(this.currentRootSpan != root) {
-            return debug('currentRootSpan != root on notifyEnd. Possbile implementation bug.') 
+             debug('currentRootSpan != root on notifyEnd. Need more investigation.') 
         }
-        this.notifyEndSpan(this.currentRootSpan);
+        this.notifyEndSpan(root);
         //this.clearCurrentTrace();
     }
 
-    //TODO: review
-    public runInContex<T>(fn: Func<T>): T {
-        return this.contextManager.runAndReturn (fn)
-    }
 
     public registerEndSpanListener(listner: OnEndSpanEventListener) {
             this.eventListeners.push(listner);
     }
 
     private notifyEndSpan(root: RootSpan) {
         if (this.active) {
+            debug ('starting to notify listeners the end of rootspans')
             if(this.eventListeners&&this.eventListeners.length >0) {
                 this.eventListeners.forEach((listener) => listener.onEndSpan(root))
             }

packages/opencensus-core/src/trace/types/tracetypes.ts

@@ -27,6 +27,11 @@ export interface TraceContext {
         options?: number  
 }
 
+export interface TraceOptions {
+    name:string;
+    traceContext?:TraceContext;
+}
+
 export interface OnEndSpanEventListener {
     onEndSpan(span: SpanBaseModel): void; 
 }