Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit 8fd0927

Browse files
authored
Renames DistributionData[sumSquaredDeviations] to [sumOfSquaredDeviation] (#209)
1 parent 3454bbb commit 8fd0927

File tree

8 files changed

+11
-11
lines changed

8 files changed

+11
-11
lines changed

packages/opencensus-core/src/stats/recorder.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ export class Recorder {
7070
const oldMean = distributionData.mean;
7171
distributionData.mean = distributionData.mean +
7272
(value - distributionData.mean) / distributionData.count;
73-
distributionData.sumSquaredDeviations =
74-
distributionData.sumSquaredDeviations +
73+
distributionData.sumOfSquaredDeviation =
74+
distributionData.sumOfSquaredDeviation +
7575
(value - oldMean) * (value - distributionData.mean);
7676
distributionData.stdDeviation = Math.sqrt(
77-
distributionData.sumSquaredDeviations / distributionData.count);
77+
distributionData.sumOfSquaredDeviation / distributionData.count);
7878

7979
return distributionData;
8080
}

packages/opencensus-core/src/stats/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ export interface DistributionData extends AggregationMetadata {
189189
* Get the computed sum of squared deviations of all recorded values in the
190190
* histogram.
191191
*/
192-
sumSquaredDeviations: number;
192+
sumOfSquaredDeviation: number;
193193
/** Bucket distribution of the histogram */
194194
buckets: Bucket[];
195195
/** Buckets count */

packages/opencensus-core/src/stats/view.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ export class BaseView implements View {
170170
min: Number.MAX_SAFE_INTEGER,
171171
mean: null as number,
172172
stdDeviation: null as number,
173-
sumSquaredDeviations: null as number,
173+
sumOfSquaredDeviation: null as number,
174174
buckets,
175175
bucketCounts
176176
};

packages/opencensus-core/test/test-recorder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ function assertDistributionData(
4747
values.map(value => Math.pow(value - expectedMean, 2))
4848
.reduce((acc, curr) => acc + curr);
4949
assert.ok(isAlmostEqual(
50-
distributionData.sumSquaredDeviations, expectedSumSquaredDeviations,
50+
distributionData.sumOfSquaredDeviation, expectedSumSquaredDeviations,
5151
EPSILON));
5252

5353
const expectedStdDeviation =
@@ -161,7 +161,7 @@ describe('Recorder', () => {
161161
min: Number.MAX_SAFE_INTEGER,
162162
mean: 0,
163163
stdDeviation: 0,
164-
sumSquaredDeviations: 0,
164+
sumOfSquaredDeviation: 0,
165165
buckets: [2, 4, 6],
166166
bucketCounts: [0, 0, 0, 0]
167167
};

packages/opencensus-core/test/test-view.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ function assertDistributionData(
4848
values.map(value => Math.pow(value - expectedMean, 2))
4949
.reduce((acc, curr) => acc + curr);
5050
assert.ok(isAlmostEqual(
51-
distributionData.sumSquaredDeviations, expectedSumSquaredDeviations,
51+
distributionData.sumOfSquaredDeviation, expectedSumSquaredDeviations,
5252
EPSILON));
5353

5454
const expectedStdDeviation =

packages/opencensus-exporter-stackdriver/src/stackdriver-monitoring.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ export class StackdriverStatsExporter implements StatsEventListener {
211211
return {
212212
count: distribution.count,
213213
mean: distribution.mean,
214-
sumOfSquaredDeviation: distribution.sumSquaredDeviations,
214+
sumOfSquaredDeviation: distribution.sumOfSquaredDeviation,
215215
bucketOptions: {explicitBuckets: {bounds: [0, ...distribution.buckets]}},
216216
bucketCounts: [0, ...distribution.bucketCounts]
217217
};

packages/opencensus-exporter-zpages/templates/statsz-view-distribution.ejs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<td class="borderRL"><?= data.snapshot.count ?></td>
2424
<td class="borderRL"><?= data.snapshot.max ?></td>
2525
<td class="borderRL"><?= data.snapshot.min ?></td>
26-
<td class="borderRL"><?= data.snapshot.sumSquaredDeviations ?></td>
26+
<td class="borderRL"><?= data.snapshot.sumOfSquaredDeviation ?></td>
2727
<td class="borderRL">
2828
<table>
2929
<thead>

packages/opencensus-exporter-zpages/test/test-zpages.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ describe('Zpages Exporter', () => {
409409
assert.equal(snapshot.max, 22);
410410
assert.equal(snapshot.min, 11);
411411
assert.equal(snapshot.mean, 16.5);
412-
assert.equal(snapshot.sumSquaredDeviations, 60.5);
412+
assert.equal(snapshot.sumOfSquaredDeviation, 60.5);
413413
});
414414
});
415415
});

0 commit comments

Comments
 (0)