refactor: modify sampler config to use optionsTracing

Author: eldreygalindo

packages/opencensus-core/src/trace/model/tracer.ts

@@ -37,6 +37,8 @@ export class TracerImpl implements Tracer {
     //TODO: temp solution 
     private endedTraces: RootSpan[] = [];
 
+    samplingRate: number;
+
     constructor() {
         this.activeLocal = false;
         this.contextManager = cls.createNamespace();
@@ -75,12 +77,12 @@ export class TracerImpl implements Tracer {
             if (!options) {
                 options = {} as TraceOptions;
             }
-            if (!options.sampler) {
-                options.sampler = new SamplerImpl(newRoot.traceId);
-                //options.sampler.probability(0.5);
-                options.sampler.always();
-            }
-            newRoot.sampler = options.sampler;
+            // if (!options.sampler) {
+            //     options.sampler = new SamplerImpl(newRoot.traceId);
+            //     options.sampler.always();
+            // }
+            // newRoot.sampler = options.sampler;
+            newRoot.sampler = new SamplerImpl().probability(this.samplingRate);
             if (newRoot.sampler.shouldSample(newRoot.traceId)) {
                 newRoot.start();
                 return fn(newRoot);

packages/opencensus-core/src/trace/model/types.ts

@@ -148,6 +148,9 @@ export interface RootSpan extends Span, OnEndSpanEventListener {
 export interface Tracer  {
     /** Get and set the currentRootSpan to tracer instance */
     currentRootSpan: RootSpan;
+    
+    samplingRate: number;
+    
     /** Get the eventListeners from tracer instance */
     readonly eventListeners: OnEndSpanEventListener[];
     /** Get the active status from tracer instance */

packages/opencensus-core/src/trace/sampler/sampler.ts

@@ -64,14 +64,14 @@ export class SamplerImpl {
    * @param probability probability between 0 and 1
    * @returns a Sampler object
    */
-  probability(probability: number): Sampler {
-    if (probability < MIN_NUMBER) {
-      return this.never();
-
-    } else if (probability > MAX_NUMBER) {
+  probability(probability?: number): Sampler {
+    if(!probability || probability > MAX_NUMBER) {
       return this.always();
     }
+    else if (probability < MIN_NUMBER) {
+      return this.never();
 
+    }
     this.idUpperBound = probability * MAX_NUMBER;
     return this;
   }
@@ -93,4 +93,18 @@ export class SamplerImpl {
       return false;
     }
   }
+
+  // setRate(samplerRate?:number){
+  //   if(samplerRate){
+  //     if(samplerRate <= MIN_NUMBER){
+  //       this.never();
+  //     }else if(samplerRate >= MAX_NUMBER){
+  //       this.always();
+  //     }else{
+  //       this.probability(samplerRate);
+  //     }
+  //   }else{
+  //     this.always();
+  //   }
+  // }
 }

packages/opencensus-core/src/trace/types.ts

@@ -19,10 +19,13 @@ import {Sampler} from './config/types';
 import {Exporter} from '../exporters/types';
 
 
-export interface  Tracing {
+export interface Tracing {
   readonly tracer: Tracer;
-  readonly sampler: Sampler;
+  // readonly sampler: Sampler;
   readonly exporter: Exporter;
-  start(): Tracing;
+  start(opstion?:OptionsTracing): Tracing;
   stop(): void;
 }
+export interface OptionsTracing {
+  samplingRate ?: number;
+}