Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit d6f2fe3

Browse files
fabiogomessilvakjin
authored andcommitted
refactor: tsconfig from core package (#35)
refactor: tsconfig.ts from core package
1 parent 51f06fb commit d6f2fe3

6 files changed

Lines changed: 18 additions & 24 deletions

File tree

packages/opencensus-core/src/common/console-logger.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,15 @@
1515
*/
1616

1717
import * as util from 'util';
18-
1918
import * as types from './types';
2019

2120
const logDriver = require('log-driver');
2221

23-
2422
/**
2523
* This class implements a console logger.
2624
*/
2725
export class ConsoleLogger implements types.Logger {
28-
// tslint:disable:no-any
29-
private logger: any;
26+
private logger: typeof logDriver;
3027
static LEVELS = ['silent', 'error', 'warn', 'info', 'debug', 'silly'];
3128
level: string;
3229

@@ -61,7 +58,7 @@ export class ConsoleLogger implements types.Logger {
6158
* @param message menssage erro to log in console
6259
* @param args arguments to log in console
6360
*/
64-
// tslint:disable:no-any
61+
// tslint:disable-next-line:no-any
6562
error(message: any, ...args: any[]): void {
6663
this.logger.error(util.format(message, ...args));
6764
}
@@ -71,7 +68,7 @@ export class ConsoleLogger implements types.Logger {
7168
* @param message menssage warning to log in console
7269
* @param args arguments to log in console
7370
*/
74-
// tslint:disable:no-any
71+
// tslint:disable-next-line:no-any
7572
warn(message: any, ...args: any[]): void {
7673
this.logger.warn(util.format(message, ...args));
7774
}
@@ -81,7 +78,7 @@ export class ConsoleLogger implements types.Logger {
8178
* @param message menssage info to log in console
8279
* @param args arguments to log in console
8380
*/
84-
// tslint:disable:no-any
81+
// tslint:disable-next-line:no-any
8582
info(message: any, ...args: any[]): void {
8683
this.logger.info(util.format(message, ...args));
8784
}
@@ -91,7 +88,7 @@ export class ConsoleLogger implements types.Logger {
9188
* @param message menssage debug to log in console
9289
* @param args arguments to log in console
9390
*/
94-
// tslint:disable:no-any
91+
// tslint:disable-next-line:no-any
9592
debug(message: any, ...args: any[]): void {
9693
this.logger.debug(util.format(message, ...args));
9794
}
@@ -101,7 +98,7 @@ export class ConsoleLogger implements types.Logger {
10198
* @param message menssage silly to log in console
10299
* @param args arguments to log in console
103100
*/
104-
// tslint:disable:no-any
101+
// tslint:disable-next-line:no-any
105102
silly(message: any, ...args: any[]): void {
106103
this.logger.silly(util.format(message, ...args));
107104
}
@@ -115,7 +112,8 @@ export class ConsoleLogger implements types.Logger {
115112
* Function logger exported to others classes.
116113
* @param options A logger options or strig to logger in console
117114
*/
118-
const logger = (options?: types.LoggerOptions|string|number) => {
115+
// tslint:disable-next-line:no-any
116+
const logger: any = (options?: types.LoggerOptions|string|number) => {
119117
const aLogger = new ConsoleLogger(options);
120118
logger['logger'] = aLogger;
121119
return aLogger;

packages/opencensus-core/test/test-console-logger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ let consoleTxt = '';
3030

3131
describe('ConsoleLogger', () => {
3232
const intercept = require('intercept-stdout');
33-
const unhookIntercept = intercept((txt) => {
33+
const unhookIntercept = intercept((txt: string) => {
3434
consoleTxt = txt;
3535
return txt;
3636
});

packages/opencensus-core/test/test-root-span.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import * as mocha from 'mocha';
2020
import {RootSpan} from '../src/trace/model/root-span';
2121
import {Span} from '../src/trace/model/span';
2222
import {Tracer} from '../src/trace/model/tracer';
23+
import * as types from '../src/trace/model/types';
2324
import {Annotation, Attributes, Link, MessageEvent, TraceOptions} from '../src/trace/model/types';
2425

2526
const tracer = new Tracer();
@@ -92,7 +93,7 @@ describe('RootSpan', () => {
9293
* Should create and start a new span instance
9394
*/
9495
describe('startSpan()', () => {
95-
let root, span;
96+
let root: types.RootSpan, span: types.Span;
9697

9798
before(() => {
9899
root = new RootSpan(tracer);

packages/opencensus-core/test/test-span.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import * as mocha from 'mocha';
2020
import {RootSpan} from '../src/trace/model/root-span';
2121
import {Span} from '../src/trace/model/span';
2222
import {Tracer} from '../src/trace/model/tracer';
23+
import * as types from '../src/trace/model/types';
2324
import {Annotation, Attributes, Link, MessageEvent} from '../src/trace/model/types';
2425

2526

@@ -74,7 +75,7 @@ describe('Span', () => {
7475
* clock instance created
7576
*/
7677
describe('get time properties before start()', () => {
77-
let span;
78+
let span: types.Span;
7879
before(() => {
7980
const rootSpan = new RootSpan(tracer);
8081
rootSpan.start();

packages/opencensus-core/test/test-tracer.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe('Tracer', () => {
6565

6666
/** Should return a started tracer instance */
6767
describe('start()', () => {
68-
let tracerStarted;
68+
let tracerStarted: types.Tracer;
6969
before(() => {
7070
const tracer = new Tracer();
7171
assert.strictEqual(tracer.active, false);
@@ -82,7 +82,7 @@ describe('Tracer', () => {
8282

8383
/** Should return an OnEndSpanEventListener list */
8484
describe('registerSpanEventListener() / get eventListeners()', () => {
85-
let tracer, onEndSpan;
85+
let tracer: types.Tracer, onEndSpan: OnEndSpanClass;
8686
before(() => {
8787
tracer = new Tracer();
8888
onEndSpan = new OnEndSpanClass();
@@ -117,7 +117,7 @@ describe('Tracer', () => {
117117

118118
/** Should create and start a new RootSpan instance */
119119
describe('startRootSpan()', () => {
120-
let rootSpanLocal;
120+
let rootSpanLocal: types.RootSpan;
121121
before(() => {
122122
const tracer = new Tracer();
123123
tracer.start(defaultConfig);
@@ -135,7 +135,7 @@ describe('Tracer', () => {
135135

136136
/** Should create and start a new RootSpan instance with options */
137137
describe('startRootSpan() with options', () => {
138-
let rootSpanLocal;
138+
let rootSpanLocal: types.RootSpan;
139139
before(() => {
140140
const tracer = new Tracer();
141141
tracer.start(defaultConfig);

packages/opencensus-core/tsconfig.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,10 @@
33
"compilerOptions": {
44
"rootDir": ".",
55
"outDir": "build",
6-
"allowUnreachableCode": true,
7-
"noUnusedParameters": false,
8-
"noImplicitAny": false,
9-
"noImplicitThis": false,
10-
"noEmitOnError": false,
116
"pretty": true,
12-
"strict": false,
137
"module": "commonjs",
148
"target": "es6",
15-
"sourceMap": false
9+
"strictNullChecks": false
1610
},
1711
"include": [
1812
"src/**/*.ts",

0 commit comments

Comments
 (0)