Clean up test warnings (#164)

* Failing tests after setting error_reporting to E_ALL

* Fix warnings

Author: chingor13

Dockerfile

@@ -29,6 +29,8 @@ RUN mkdir -p /build && \
 
 COPY . /build/
 
+COPY config/php.ini /usr/local/etc/php/
+
 WORKDIR /build/ext
 
 ENV TEST_PHP_ARGS="-q" \

config/php.ini

@@ -0,0 +1 @@
+error_reporting = E_ALL

src/Trace/Exporter/FileExporter.php

@@ -70,7 +70,7 @@ public function export(array $spans)
      */
     private function convertSpans(array $spans)
     {
-        return array_map(function (SpanData $span) use ($traceId) {
+        return array_map(function (SpanData $span) {
             return [
                 'traceId' => $span->traceId(),
                 'name' => $span->name(),

tests/unit/Trace/Exporter/LoggerExporterTest.php

@@ -68,6 +68,6 @@ public function testLogsTrace()
         $this->logger->log('some-level', Argument::type('string'))->shouldBeCalled();
 
         $exporter = new LoggerExporter($this->logger->reveal(), 'some-level');
-        $this->assertTrue($exporter->export([$span->spanData]));
+        $this->assertTrue($exporter->export([$span->spanData()]));
     }
 }

tests/unit/Trace/Exporter/StackdriverExporterTest.php

@@ -179,10 +179,7 @@ public function testReportsVersionAttribute()
             ->willReturn(true)->shouldBeCalled();
 
         $span = new OCSpan([
-            'traceId' => 'aaa',
-            'attributes' => [
-                $key => $value
-            ]
+            'traceId' => 'aaa'
         ]);
         $span->setStartTime();
         $span->setEndTime();

tests/unit/Trace/Exporter/ZipkinExporterTest.php

@@ -91,6 +91,19 @@ public function testSpanKind($spanOpts, $kind)
         $this->assertEquals($kind, $spans[0]['kind']);
     }
 
+    public function testUnspecifiedSpanKind()
+    {
+        $span = new Span([
+            'kind' => Span::KIND_UNSPECIFIED
+        ]);
+        $span->setStartTime();
+        $span->setEndTime();
+        $exporter = new ZipkinExporter('myapp');
+        $spans = $exporter->convertSpans([$span->spanData()]);
+
+        $this->assertArrayNotHasKey('kind', $spans[0]);
+    }
+
     public function spanOptionsForKind()
     {
         return [
@@ -99,8 +112,7 @@ public function spanOptionsForKind()
             [['name' => 'span3', 'timeEvents' => [new MessageEvent(MessageEvent::TYPE_RECEIVED, '')]], 'SERVER'],
             [['name' => 'span4', 'timeEvents' => [new MessageEvent(MessageEvent::TYPE_SENT, '')]], 'CLIENT'],
             [['kind' => Span::KIND_SERVER], 'SERVER'],
-            [['kind' => Span::KIND_CLIENT], 'CLIENT'],
-            [['kind' => Span::KIND_UNSPECIFIED], null]
+            [['kind' => Span::KIND_CLIENT], 'CLIENT']
         ];
     }