Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit e7dbba3

Browse files
Emmanuel T Odekesongy23
authored andcommitted
agent/trace/v1: fix signature for Config and comments too (#91)
* Fix the signature for Config since the service sends down to applications on a stream of ConfigTraceServiceRequests and receives responses on a stream of ConfigTraceServiceResponses * Update TraceService comments Fixes #89
1 parent 10f8683 commit e7dbba3

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

opencensus/proto/agent/trace/v1/trace_service.proto

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,13 @@ option java_outer_classname = "TraceServiceProto";
3030
option go_package = "github.com/census-instrumentation/opencensus-proto/gen-go/agent/trace/v1";
3131

3232
service TraceService {
33+
// After initialization, this RPC must be kept alive for the
34+
// entire life of the application. The agent pushes configs
35+
// down to applications via a stream of requests.
36+
rpc Config(stream ConfigTraceServiceResponse) returns (stream ConfigTraceServiceRequest) {}
3337

34-
// After the initialization this RPC must be kept alive for the
35-
// entire life of the application. Agent pushes configs to the
36-
// application via a stream of responses.
37-
rpc Config(stream ConfigTraceServiceRequest) returns (stream ConfigTraceServiceResponse) {}
38-
39-
// Allow to export Spans.
40-
// For performance reason, it is recommended to keep this RPC
38+
// Allows applications to send spans to the agent.
39+
// For performance reasons, it is recommended to keep this RPC
4140
// alive for the entire life of the application.
4241
rpc Export(stream ExportTraceServiceRequest) returns (stream ExportTraceServiceResponse) {}
4342
}

0 commit comments

Comments
 (0)