Skip to content
This repository was archived by the owner on Nov 7, 2022. It is now read-only.

Commit b935796

Browse files
Paulo JanottiBogdan Drutu
authored andcommitted
Add logger to construction methods. (#483)
Opportunistic fix: renamed the files of factorytemplate package.
1 parent 9fa7389 commit b935796

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

receiver/factorytemplate/factory_template.go renamed to receiver/factorytemplate/factorytemplate.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@ type factory struct {
5151

5252
type traceReceiverFactory struct {
5353
factory
54-
newReceiver func(interface{}, consumer.TraceConsumer) (receiver.TraceReceiver, error)
54+
newReceiver func(interface{}, consumer.TraceConsumer, *zap.Logger) (receiver.TraceReceiver, error)
5555
}
5656

5757
var _ (receiver.TraceReceiverFactory) = (*traceReceiverFactory)(nil)
5858

5959
type metricsReceiverFactory struct {
6060
factory
61-
newReceiver func(interface{}, consumer.MetricsConsumer) (receiver.MetricsReceiver, error)
61+
newReceiver func(interface{}, consumer.MetricsConsumer, *zap.Logger) (receiver.MetricsReceiver, error)
6262
}
6363

6464
var _ (receiver.MetricsReceiverFactory) = (*metricsReceiverFactory)(nil)
@@ -77,7 +77,7 @@ var _ (receiver.MetricsReceiverFactory) = (*metricsReceiverFactory)(nil)
7777
func NewTraceReceiverFactory(
7878
receiverType string,
7979
newDefaulfCfg func() interface{},
80-
newReceiver func(interface{}, consumer.TraceConsumer) (receiver.TraceReceiver, error),
80+
newReceiver func(interface{}, consumer.TraceConsumer, *zap.Logger) (receiver.TraceReceiver, error),
8181
) (receiver.TraceReceiverFactory, error) {
8282
if receiverType == "" {
8383
return nil, ErrEmptyReciverType
@@ -112,7 +112,7 @@ func NewTraceReceiverFactory(
112112
func NewMetricsReceiverFactory(
113113
receiverType string,
114114
newDefaulfCfg func() interface{},
115-
newReceiver func(interface{}, consumer.MetricsConsumer) (receiver.MetricsReceiver, error),
115+
newReceiver func(interface{}, consumer.MetricsConsumer, *zap.Logger) (receiver.MetricsReceiver, error),
116116
) (receiver.MetricsReceiverFactory, error) {
117117
if receiverType == "" {
118118
return nil, ErrEmptyReciverType
@@ -147,7 +147,7 @@ func (trf *traceReceiverFactory) NewFromViper(v *viper.Viper, next consumer.Trac
147147
if err != nil {
148148
return nil, err
149149
}
150-
r, err := trf.newReceiver(cfg, next)
150+
r, err := trf.newReceiver(cfg, next, logger)
151151
if err != nil {
152152
return nil, err
153153
}
@@ -165,7 +165,7 @@ func (mrf *metricsReceiverFactory) NewFromViper(v *viper.Viper, next consumer.Me
165165
if err != nil {
166166
return nil, err
167167
}
168-
r, err := mrf.newReceiver(cfg, next)
168+
r, err := mrf.newReceiver(cfg, next, logger)
169169
if err != nil {
170170
return nil, err
171171
}

receiver/factorytemplate/factory_template_test.go renamed to receiver/factorytemplate/factorytemplate_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func TestNewTraceReceiverFactory(t *testing.T) {
3535
type args struct {
3636
receiverType string
3737
newDefaultCfg func() interface{}
38-
newReceiver func(interface{}, consumer.TraceConsumer) (receiver.TraceReceiver, error)
38+
newReceiver func(interface{}, consumer.TraceConsumer, *zap.Logger) (receiver.TraceReceiver, error)
3939
}
4040
tests := []struct {
4141
name string
@@ -104,7 +104,7 @@ func TestNewMetricsReceiverFactory(t *testing.T) {
104104
type args struct {
105105
receiverType string
106106
newDefaultCfg func() interface{}
107-
newReceiver func(interface{}, consumer.MetricsConsumer) (receiver.MetricsReceiver, error)
107+
newReceiver func(interface{}, consumer.MetricsConsumer, *zap.Logger) (receiver.MetricsReceiver, error)
108108
}
109109
tests := []struct {
110110
name string
@@ -283,7 +283,7 @@ func Test_traceReceiverFactory_NewFromViper_Errors(t *testing.T) {
283283
},
284284
}
285285

286-
newTraceReceiverAlwaysFail := func(cfg interface{}, next consumer.TraceConsumer) (receiver.TraceReceiver, error) {
286+
newTraceReceiverAlwaysFail := func(cfg interface{}, next consumer.TraceConsumer, logger *zap.Logger) (receiver.TraceReceiver, error) {
287287
return nil, errNewReceiver
288288
}
289289
factory, err := NewTraceReceiverFactory(
@@ -368,7 +368,7 @@ func Test_metricsReceiverFactory_NewFromViper_Errors(t *testing.T) {
368368
},
369369
}
370370

371-
newMetricsReceiverAlwaysFail := func(cfg interface{}, next consumer.MetricsConsumer) (receiver.MetricsReceiver, error) {
371+
newMetricsReceiverAlwaysFail := func(cfg interface{}, next consumer.MetricsConsumer, logger *zap.Logger) (receiver.MetricsReceiver, error) {
372372
return nil, errNewReceiver
373373
}
374374

@@ -435,7 +435,7 @@ func Examplefactory_DefaultConfig() {
435435
templateArgs := []struct {
436436
receiverType string
437437
newDefaultCfg func() interface{}
438-
newReceiver func(interface{}, consumer.TraceConsumer) (receiver.TraceReceiver, error)
438+
newReceiver func(interface{}, consumer.TraceConsumer, *zap.Logger) (receiver.TraceReceiver, error)
439439
}{
440440
{
441441
receiverType: "mockReceiver",
@@ -477,7 +477,7 @@ func checkedBuildReceiverFactory(
477477
t *testing.T,
478478
receiverType string,
479479
newDefaultCfg func() interface{},
480-
newReceiver func(interface{}, consumer.TraceConsumer) (receiver.TraceReceiver, error),
480+
newReceiver func(interface{}, consumer.TraceConsumer, *zap.Logger) (receiver.TraceReceiver, error),
481481
) receiver.TraceReceiverFactory {
482482
factory, err := NewTraceReceiverFactory(receiverType, newDefaultCfg, newReceiver)
483483
if err != nil {
@@ -509,13 +509,13 @@ func altNewMockReceiverDefaultCfg() interface{} {
509509
}
510510
}
511511

512-
func newMockTraceReceiver(cfg interface{}, next consumer.TraceConsumer) (receiver.TraceReceiver, error) {
512+
func newMockTraceReceiver(cfg interface{}, next consumer.TraceConsumer, logger *zap.Logger) (receiver.TraceReceiver, error) {
513513
return &mockReceiver{
514514
config: cfg.(*mockReceiverCfg),
515515
}, nil
516516
}
517517

518-
func newMockMetricsReceiver(cfg interface{}, next consumer.MetricsConsumer) (receiver.MetricsReceiver, error) {
518+
func newMockMetricsReceiver(cfg interface{}, next consumer.MetricsConsumer, logger *zap.Logger) (receiver.MetricsReceiver, error) {
519519
return &mockReceiver{
520520
config: cfg.(*mockReceiverCfg),
521521
}, nil

0 commit comments

Comments
 (0)