Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit 36acbf8

Browse files
author
Bogdan Drutu
authored
Remove '.' from the tag names in grpc and http specs. (#88)
* Remove '.' from the tag names in grpc and http specs. * Fix all tag names.
1 parent f1fa63e commit 36acbf8

2 files changed

Lines changed: 16 additions & 16 deletions

File tree

stats/HTTP.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ All client metrics should be tagged with the following.
3636

3737
| Tag suffix | Description |
3838
|--------------------|----------------------------------------------------------------------------------------------------------|
39-
| http.client_method | HTTP method, capitalized (i.e. GET, POST, PUT, DELETE, etc.) |
40-
| http.client_path | URL path (not including query string) |
41-
| http.client_status | HTTP status code as an integer (e.g. 200, 404, 500.), or "error" if no response status line was received |
42-
| http.client_host | Value of the request Host header |
39+
| http_client_method | HTTP method, capitalized (i.e. GET, POST, PUT, DELETE, etc.) |
40+
| http_client_path | URL path (not including query string) |
41+
| http_client_status | HTTP status code as an integer (e.g. 200, 404, 500.), or "error" if no response status line was received |
42+
| http_client_host | Value of the request Host header |
4343

4444
### Default views
4545

@@ -69,15 +69,15 @@ Server stats are recorded for each individual HTTP request, including for each r
6969
### Tags
7070

7171
All server metrics should be tagged with the following.
72-
`http.server_method`, `http.server_path`, `http.server_host` are available in the context for the entire request processing.
73-
`http.server_status` is only available around the stats recorded at the end of request processing.
72+
`http_server_method`, `http_server_path`, `http_server_host` are available in the context for the entire request processing.
73+
`http_server_status` is only available around the stats recorded at the end of request processing.
7474

7575
| Tag suffix | Description |
7676
|--------------------|---------------------------------------------------------------------|
77-
| http.server_method | HTTP method, capitalized (i.e. GET, POST, PUT, DELETE, etc.) |
78-
| http.server_path | URL path (not including query string) |
79-
| http.server_status | HTTP server status code returned, as an integer e.g. 200, 404, 500. |
80-
| http.server_host | Value of the request Host header |
77+
| http_server_method | HTTP method, capitalized (i.e. GET, POST, PUT, DELETE, etc.) |
78+
| http_server_path | URL path (not including query string) |
79+
| http_server_status | HTTP server status code returned, as an integer e.g. 200, 404, 500. |
80+
| http_server_host | Value of the request Host header |
8181

8282
### Default views
8383

stats/gRPC.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ All client metrics should be tagged with the following.
4444

4545
| Tag name | Description |
4646
|--------------------|------------------------------------------------------------------------------------------------------------------|
47-
| grpc.client_method | Full gRPC method name, including package, service and method, e.g. google.bigtable.v2.Bigtable/CheckAndMutateRow |
48-
| grpc.client_status | gRPC server status code received, e.g. OK, CANCELLED, DEADLINE_EXCEEDED |
47+
| grpc_client_method | Full gRPC method name, including package, service and method, e.g. google.bigtable.v2.Bigtable/CheckAndMutateRow |
48+
| grpc_client_status | gRPC server status code received, e.g. OK, CANCELLED, DEADLINE_EXCEEDED |
4949

5050
### Default views
5151

@@ -86,11 +86,11 @@ All server metrics should be tagged with the following.
8686

8787
| Tag name | Description |
8888
|--------------------|----------------------------------------------------------------------------------------------------------------|
89-
| grpc.server_method | Full gRPC method name, including package, service and method, e.g. com.exampleapi.v4.BookshelfService/Checkout |
90-
| grpc.server_status | gRPC server status code returned, e.g. OK, CANCELLED, DEADLINE_EXCEEDED |
89+
| grpc_server_method | Full gRPC method name, including package, service and method, e.g. com.exampleapi.v4.BookshelfService/Checkout |
90+
| grpc_server_status | gRPC server status code returned, e.g. OK, CANCELLED, DEADLINE_EXCEEDED |
9191

92-
`grpc.server_method` is available in the context for the entire RPC call handling.
93-
`grpc.server_status` is only available around metrics recorded at the end of the request.
92+
`grpc_server_method` is available in the context for the entire RPC call handling.
93+
`grpc_server_status` is only available around metrics recorded at the end of the request.
9494

9595
### Default views
9696

0 commit comments

Comments
 (0)