Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit 81f67e4

Browse files
author
Bogdan Drutu
authored
Fixes not pushed in the highlevel design PR. (#16)
1 parent 252447a commit 81f67e4

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ The key elements of the API can be broken down as:
7979
etc.).
8080
* Spans are carried in the Context. Libraries MUST provide a way of getting, manipulating,
8181
and replacing the Span in the current context.
82-
* Libraries MUST provide a means of dynamically controlling the trace global config at runtime (e
82+
* Libraries SHOULD provide a means of dynamically controlling the trace global config at runtime (e
8383
.g. trace sampling rate/probability).
8484
* Libraries SHOULD keep track of active spans and in memory samples based on latency/errors and
8585
offer ways to access the data.
@@ -136,11 +136,11 @@ allows applications to easily get access to their own data in-process.
136136
* Library MUST support the [TraceContext][TraceContextSpecs] format for Trace and Tags components.
137137
* Binary encoding is defined [here](https://github.com/census-instrumentation/opencensus-specs/blob/master/encodings/BinaryEncoding.md)
138138

139-
[EcosystemLayers]: https://github.com/census-instrumentation/opencensus-specs/blob/master/drawings/EcosystemLayers.png "Ecosystem Layer"
139+
[EcosystemLayers]: https://github.com/census-instrumentation/opencensus-specs/blob/master/drawings/EcosystemLayers.jpg "Ecosystem Layer"
140140
[DapperPaper]: https://research.google.com/pubs/pub36356.html
141141
[goContext]: https://golang.org/pkg/context
142142
[gRPCContext]: https://github.com/grpc/grpc-java/blob/master/context/src/main/java/io/grpc/Context.java
143-
[LibraryComponents]: https://github.com/census-instrumentation/opencensus-specs/blob/master/drawings/LibraryComponents.png "OpenCensus Library Components"
143+
[LibraryComponents]: https://github.com/census-instrumentation/opencensus-specs/blob/master/drawings/LibraryComponents.jpg "OpenCensus Library Components"
144144
[NamespaceAndPackage]: https://github.com/census-instrumentation/opencensus-specs/blob/master/NamespaceAndPackage.md
145145
[RFC2119]: https://www.ietf.org/rfc/rfc2119.txt
146146
[TraceAPI]: https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/README.md

drawings/LibraryComponents.jpg

-685 Bytes
Loading

0 commit comments

Comments
 (0)