Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit dc6f3ee

Browse files
author
Bogdan Drutu
authored
Clarify when rpc/http tags are added (#96)
1 parent b3cb170 commit dc6f3ee

2 files changed

Lines changed: 20 additions & 4 deletions

File tree

stats/HTTP.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@ All client metrics should be tagged with the following.
4141
| http_client_status | HTTP status code as an integer (e.g. 200, 404, 500.), or "error" if no response status line was received |
4242
| http_client_host | Value of the request Host header |
4343

44+
`http_client_method`, `http_client_path`, `http_client_host` are set when an outgoing request
45+
starts and are available in the context for the entire outgoing request processing.
46+
`http_client_status` is set when an outgoing request finishes and is only available around the
47+
stats recorded at the end of request processing.
48+
49+
4450
### Default views
4551

4652
The following set of views are considered minimum required to monitor client side performance:
@@ -69,8 +75,6 @@ Server stats are recorded for each individual HTTP request, including for each r
6975
### Tags
7076

7177
All server metrics should be tagged with the following.
72-
`http_server_method`, `http_server_path`, `http_server_host` are available in the context for the entire request processing.
73-
`http_server_status` is only available around the stats recorded at the end of request processing.
7478

7579
| Tag suffix | Description |
7680
|--------------------|---------------------------------------------------------------------|
@@ -79,6 +83,11 @@ All server metrics should be tagged with the following.
7983
| http_server_status | HTTP server status code returned, as an integer e.g. 200, 404, 500. |
8084
| http_server_host | Value of the request Host header |
8185

86+
`http_server_method`, `http_server_path`, `http_server_host` are set when an incoming request
87+
starts and are available in the context for the entire incoming request processing.
88+
`http_server_status` is set when an incoming request finishes and is only available around the stats
89+
recorded at the end of request processing.
90+
8291
### Default views
8392

8493
The following set of views are considered minimum required to monitor server side performance:

stats/gRPC.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@ All client metrics should be tagged with the following.
4747
| grpc_client_method | Full gRPC method name, including package, service and method, e.g. google.bigtable.v2.Bigtable/CheckAndMutateRow |
4848
| grpc_client_status | gRPC server status code received, e.g. OK, CANCELLED, DEADLINE_EXCEEDED |
4949

50+
`grpc_client_method` is set when an outgoing request starts and is available in all the recorded
51+
metrics.
52+
`grpc_client_status` is set when an outgoing request finishes and is only available around metrics
53+
recorded at the end of the outgoing request.
54+
5055
### Default views
5156

5257
The following set of views are considered minimum required to monitor client-side performance:
@@ -89,8 +94,10 @@ All server metrics should be tagged with the following.
8994
| grpc_server_method | Full gRPC method name, including package, service and method, e.g. com.exampleapi.v4.BookshelfService/Checkout |
9095
| grpc_server_status | gRPC server status code returned, e.g. OK, CANCELLED, DEADLINE_EXCEEDED |
9196

92-
`grpc_server_method` is available in the context for the entire RPC call handling.
93-
`grpc_server_status` is only available around metrics recorded at the end of the request.
97+
`grpc_server_method` is set when an incoming request starts and is available in the context for
98+
the entire RPC call handling.
99+
`grpc_server_status` is set when an incoming request finishes and is only available around metrics
100+
recorded at the end of the incoming request.
94101

95102
### Default views
96103

0 commit comments

Comments
 (0)