Issue #440: resolves AvoidHidingCauseException

Author: Calixte

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationWorkingCopy.java

@@ -288,27 +288,27 @@ public boolean isConfigInUse(ICheckConfiguration configuration) {
 
   @Override
   public Object clone() {
-    ProjectConfigurationWorkingCopy clone = null;
+    ProjectConfigurationWorkingCopy clone;
     try {
       clone = (ProjectConfigurationWorkingCopy) super.clone();
-      clone.fileSets = new LinkedList<>();
-      clone.setUseSimpleConfig(this.isUseSimpleConfig());
-      clone.setSyncFormatter(this.isSyncFormatter());
+    } catch (CloneNotSupportedException ex) {
+      throw new IllegalStateException(ex);
+    }
+    clone.fileSets = new LinkedList<>();
+    clone.setUseSimpleConfig(this.isUseSimpleConfig());
+    clone.setSyncFormatter(this.isSyncFormatter());
 
-      // clone file sets
-      for (FileSet fileSet : fileSets) {
-        clone.getFileSets().add(fileSet.clone());
-      }
+    // clone file sets
+    for (FileSet fileSet : fileSets) {
+      clone.getFileSets().add(fileSet.clone());
+    }
 
-      // clone filters
-      List<IFilter> clonedFilters = new ArrayList<>();
-      for (IFilter filter : filters) {
-        clonedFilters.add(filter.clone());
-      }
-      clone.filters = clonedFilters;
-    } catch (CloneNotSupportedException ex) {
-      throw new InternalError();
+    // clone filters
+    List<IFilter> clonedFilters = new ArrayList<>();
+    for (IFilter filter : filters) {
+      clonedFilters.add(filter.clone());
     }
+    clone.filters = clonedFilters;
 
     return clone;
   }

net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/AbstractFilter.java

@@ -118,15 +118,12 @@ public String getPresentableFilterData() {
 
   @Override
   public IFilter clone() {
-
-    IFilter object = null;
     try {
-      object = (IFilter) super.clone();
+      return (IFilter) super.clone();
     } catch (CloneNotSupportedException cnse) {
       // this shouldn't happen, since we are Cloneable
-      throw new InternalError();
+      throw new IllegalStateException(cnse);
     }
-    return object;
   }
 
   @Override