Skip to content

Commit e3e4e62

Browse files
authored
fix(multiple): Fix checking of multi value field (drupal-graphql#1168)
1 parent 5da9890 commit e3e4e62

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/Plugin/GraphQL/DataProducer/EntityDefinition/Fields/Multiple.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public function resolve(FieldDefinitionInterface $entity_definition_field): bool
3838
if ($entity_definition_field instanceof FieldStorageDefinitionInterface) {
3939
return $entity_definition_field->isMultiple();
4040
}
41-
return $entity_definition_field->isList();
41+
return $entity_definition_field->getFieldStorageDefinition()->isMultiple();
4242
}
4343

4444
}

tests/src/Kernel/DataProducer/EntityDefinitionTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace Drupal\Tests\graphql\Kernel\DataProducer;
44

55
use Drupal\Core\Entity\Entity\EntityFormDisplay;
6+
use Drupal\Core\Field\FieldStorageDefinitionInterface;
67
use Drupal\field\Entity\FieldConfig;
78
use Drupal\field\Entity\FieldStorageConfig;
89
use Drupal\Tests\graphql\Kernel\GraphQLTestBase;
@@ -319,7 +320,7 @@ class EntityDefinitionTest extends GraphQLTestBase {
319320
'type' => 'text',
320321
'required' => FALSE,
321322
'multiple' => TRUE,
322-
'maxNumItems' => 1,
323+
'maxNumItems' => -1,
323324
'status' => TRUE,
324325
'defaultValue' => NULL,
325326
'isReference' => FALSE,
@@ -346,6 +347,7 @@ public function setUp(): void {
346347
'field_name' => 'field_test',
347348
'type' => 'text',
348349
'entity_type' => 'node',
350+
'cardinality' => FieldStorageDefinitionInterface::CARDINALITY_UNLIMITED,
349351
]);
350352
$field_storage->save();
351353

0 commit comments

Comments
 (0)