yet more work on type reflection warnings in clojure.core

Author: dmiller

Clojure/Clojure.Source/clojure/core_deftype.clj

@@ -668,8 +668,8 @@
 
 (defn- assert-same-protocol [protocol-var method-syms]
   (doseq [m method-syms]
-    (let [v (resolve m)
-          p (:protocol (meta v))]
+    (let [^clojure.lang.Var v (resolve m)                                        ;;; Added type hint. Though resolve can return many things, the usage below -- (.sym v) -- implies that it is a Var
+          ^clojure.lang.Var p (:protocol (meta v))]                              ;;; Similar.
       (when (and v (bound? v) (not= protocol-var p))
         (binding [*out* *err*]
           (println "Warning: protocol" protocol-var "is overwriting"

Clojure/Clojure.Source/clojure/main.clj

@@ -134,7 +134,7 @@
   its behavior of both supporting .unread and collapsing all of CR, LF, and
   CRLF to a single \\newline."
   [s]
-  (let [c (.Read s)]                             ;;; .read
+  (let [c (.Read s)]                             ;;; .read          because of the indeterminate type of s, we can't type hint and thus can't get rid of reflection here and similar locations
     (cond
      (= c (int \newline)) :line-start
      (= c -1) :stream-end

Clojure/Clojure/Lib/RT.cs

@@ -234,7 +234,7 @@ public static readonly Var ReaderResolverVar
 
         public static readonly Var WarnOnReflectionVar
             //= Var.intern(CLOJURE_NS, Symbol.intern("*warn-on-reflection*"), RT.F);
-            = Var.intern(ClojureNamespace, Symbol.intern("*warn-on-reflection*"), true).setDynamic();  // TODO: Temporary so that we get warnings when compiling clojure.core
+            = Var.intern(ClojureNamespace, Symbol.intern("*warn-on-reflection*"), false).setDynamic();
 
         //public static readonly Var MACRO_META 
         //    = Var.intern(CLOJURE_NS, Symbol.intern("*macro-meta*"), null);