CLJCLR-169 -- include [ as a character triggering full ClrTypeSpec resolution

Author: dmiller

Clojure/Clojure/Lib/PersistentTreeMap.cs

@@ -610,7 +610,7 @@ static Node Append(Node left, Node right)
                     ? MakeRed(app.Key, app.Val,
                                   MakeBlack(left.Key, left.Val, left.Left, app.Left),
                                   MakeBlack(right.Key, right.Val, app.Right, right.Right))
-                                  : BalanceLeftDel(left.Key, left.Val, left.Left, MakeBlack(right.Key, right.Val, app, right.Right));
+                    : BalanceLeftDel(left.Key, left.Val, left.Left, MakeBlack(right.Key, right.Val, app, right.Right));
             }
         }
 

Clojure/Clojure/Lib/RT.cs

@@ -2753,7 +2753,7 @@ public static string PrintToConsole(object x)
 
         #region Locating types
 
-        static readonly char[] _triggerTypeChars = new char[] { '`', ',' };
+        static readonly char[] _triggerTypeChars = new char[] { '`', ',', '[' };
 
         public static Type classForName(string p)
         {

Clojure/Clojure/Readers/LineNumberingTextReader.cs

@@ -96,7 +96,7 @@ public override int Read()
             {
                 if (Peek() == '\n')
                 {
-                    ret = BaseReader.Read();
+                    ret = BaseReader.Read();  // TODO:  this should be base.read() okay for now with only a single character buffer, because we did a read at the top of this method, but will be wrong if we have multiple character buffer
                     ++_index;
                 }
                 else

Clojure/Clojure/Runtime/Reflector.cs

@@ -205,7 +205,7 @@ IEnumerable<MethodInfo> einfos
                     = targetType.GetMethods(flags).Where(info => info.Name == methodName && info.GetParameters().Length == arity);
                 infos = new List<MethodBase>();
                 foreach (MethodInfo minfo in einfos)
-                    if (!typeArgs.IsEmpty && minfo.ContainsGenericParameters)
+                    if (!typeArgs.IsEmpty && minfo.ContainsGenericParameters)   // TODO: Fix this -- should have match in number of type args and generic parameters  (CLJCLR-167)
                         infos.Add(minfo.MakeGenericMethod(typeArgs.ToArray()));
                     else
                         infos.Add(minfo);

Clojure/Csharp.Tests/LibTests/LispReaderTests.cs

@@ -1314,10 +1314,12 @@ public void SQOnMapMakesMap()
         public void SQOnVectorMakesVector()
         {
             Object o1 = ReadFromString("`[:b 2]");
-            //  (clojure/apply 
-            //      clojure/vector 
-            //         (clojure/concat (clojure/list :b) 
-            //                         (clojure/list 2)))
+            //  (clojure.core/apply 
+            //      clojure.core/vector 
+            //         (clojure.core/seq
+            //             (clojure.core/concat (clojure.core/list :b) 
+            //                                  (clojure.core/list 2))))
+
 
             Expect(o1).To.Be.An.Instance.Of<ISeq>();
             ISeq s = o1 as ISeq;
@@ -1352,11 +1354,11 @@ public void SQOnVectorMakesVector()
         public void SQOnSetMakesSet()
         {
             Object o1 = ReadFromString("`#{:b 2}");
-            //  (clojure/apply 
-            //      clojure/hash-set 
-            //         (clojure/seq
-            //             (clojure/concat (clojure/list :b) 
-            //                             (clojure/list 2))))
+            //  (clojure.core/apply 
+            //      clojure.core/hash-set 
+            //         (clojure.core/seq
+            //             (clojure.core/concat (clojure.core/list :b) 
+            //                                  (clojure.core/list 2))))
 
             Expect(o1).To.Be.An.Instance.Of<ISeq>();
             ISeq s = o1 as ISeq;