Update TargetFrameworks for Clojure.Tests and Clojure.Tests.Support

Author: dmiller

Clojure/Clojure.Tests.Support/Clojure.Tests.Support.csproj

@@ -1,8 +1,12 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-	  <TargetFrameworks>netstandard2.1;netstandard2.0</TargetFrameworks>
+	  <TargetFrameworks>net6.0;net8.0;net9.0;net462</TargetFrameworks>
 	  <LangVersion>12.0</LangVersion>
   </PropertyGroup>
 
+  <ItemGroup>
+    <ProjectReference Include="..\Clojure\Clojure.csproj" />
+  </ItemGroup>
+
 </Project>

Clojure/Clojure.Tests.Support/SwissArmy.cs

@@ -1,13 +1,16 @@
-using System;
+using clojure.lang;
+using System;
 
 namespace clojure.test;
 
 // duplicates class in JVM code
 
 public class SwissArmy
 {
+    // We cannot name this the same as the other doppelganggers (methods, static and instance) -- compiler error
+    public static String Doppelganger = "static-field";
     public string ctorId;
-
+    public static IFn idFn = clojure.clr.api.Clojure.var("clojure.core", "identity");
 
     public SwissArmy() { this.ctorId = "1"; }
     public SwissArmy(int a, long b) { this.ctorId = "2"; }
@@ -42,4 +45,5 @@ public class SwissArmy
     public static String staticArityOverloadMethod(int a, int b) { return "System.Int32-System.Int32"; }
     public static String staticArityOverloadMethod(int a, int b, int c) { return "System.Int32-System.Int32-System.Int32"; }
     public static String doppelganger(int a, int b, long c) { return "System.Int32-System.Int32-System.Int64"; }
+    public static String doppelganger() { return ""; }
 }

Clojure/Clojure.Tests/Clojure.Tests.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.1;netstandard2.0</TargetFrameworks>
-    <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
+	  <TargetFrameworks>net6.0;net8.0;net9.0;net462</TargetFrameworks>
+	  <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
   </PropertyGroup>
 
   <ItemGroup>

Clojure/Clojure.Tests/clojure/test_clojure/param_tags.clj

@@ -178,6 +178,32 @@
       :instance (let [{:keys [expected actual]} (exercise-instance-method m)]
                   (is (= expected actual))))))
 
+(deftest field-overloads-method-CLJ-2899-regression
+  (testing "overloaded in value position"
+    (is (= "static-field" clojure.test.SwissArmy/doppelganger)))
+
+  (testing "overloaded in value position, w/paramtags"
+    (is (= "" (apply ^[] clojure.test.SwissArmy/doppelganger []))))
+
+  (testing "overloaded, invoke no args"
+    (is (= "" (clojure.test.SwissArmy/doppelganger))))
+
+  (testing "overloaded, invoke w/args"
+    (is (= "int-int-long" (clojure.test.SwissArmy/doppelganger (int 1) (int 2) (long 42)))))
+
+  (testing "non-overloaded, field holds IFn, invoke w/args fails"
+    (is (thrown? Exception (eval '(clojure.test.SwissArmy/idFn 42))))
+    (is (= #'clojure.core/identity clojure.test.SwissArmy/idFn)))
+
+  (testing "non-overloaded, field holds IFn, invoke  no args"
+    (is (= #'clojure.core/identity (clojure.test.SwissArmy/idFn))))
+
+  (testing "instance method overloads"
+    (is (= "int-int" (clojure.test.SwissArmy/.doppelganger (clojure.test.SwissArmy/new) (int 1) (int 2))))
+    (is (= "int-int" (apply clojure.test.SwissArmy/.doppelganger (clojure.test.SwissArmy/new) (int 1) (int 2) [])))))
+    
+
+
 (defmacro arg-tags-called-in-macro
   [a-type b-type a b]
   `(^[~a-type ~b-type] SwissArmy/staticArityOverloadMethod ~a ~b))

docs/jank-test-suite-initial-run-results.md

@@ -495,4 +495,22 @@ DONE!
 
 The other problem area is with `case`.   It should be noted that `case` passes all the tests that are in the test suite in the Clojure repo.  There is something about the specific cases in these tests that cause `case` to fail.  This will not be fun.
 
+The major test that fails is just a big case statement with lots of different types of test cases.  I started with an empty case statement and started adding test/then pairs until I got a failure, then started removing items until I got a minimal failure case.  Here it is:
 
+```clojure
+(defn f
+    [x]
+    (case x
+        3.0 :double-result      
+        true :boolean-true-result
+        false :boolean-false-result
+        :default))
+
+(map f '(3.0 true false)) ; => (:default :boolean-true-result :boolean-false-result)
+```
+The argument `3.0` does not match its case.
+
+Further investigation reveals that is related to the `:sparse-key` switch type in `case`.
+Looking at the compiled code, it is clearly hosed.
+
+> THe only solution is to hard-code binary search through the hash codes.  DONE!