compile-clj - add simple spec for :basis arg

Author: puredanger

CHANGELOG.md

@@ -1,6 +1,10 @@
 Changelog
 ===========
 
+* next
+  * compile-clj - add simple spec for :basis arg
+* v0.10.1 on Apr 28, 2024
+  * compile-clj - add required check on :basis arg
 * v0.10.0 3a2c484 on Mar 8, 2024
   * Updated deps to latest tools.deps and Clojure 1.11.2
 * v0.9.6 8e78bcc on Oct 6, 2023

src/main/clojure/clojure/tools/build/api.clj

@@ -314,7 +314,8 @@
     :class-dir ::specs/path
     :src-dirs ::specs/paths
     :compile-opts map?
-    :bindings map?)
+    :bindings map?
+    :basis ::specs/basis)
   ((requiring-resolve 'clojure.tools.build.tasks.compile-clj/compile-clj) params))
 
 (defn javac

src/main/clojure/clojure/tools/build/api/specs.clj

@@ -3,4 +3,8 @@
 
 (s/def ::lib qualified-ident?)
 (s/def ::path string?)
-(s/def ::paths (s/coll-of string?))
+(s/def ::paths (s/coll-of string?))
+
+;; there are better specs in clojure.tools.deps.specs, but no basis spec yet
+;; just doing a simple check here
+(s/def ::basis (s/nilable map?))

src/test/clojure/clojure/tools/build/tasks/test_compile_clj.clj

@@ -76,6 +76,14 @@
       (api/compile-clj (assoc compile-params :bindings {#'clojure.core/*assert* false})) ;; turn off asserts
       (is (= {:exit 0, :out (str "100" (System/lineSeparator))} (invoke))))))
 
+(deftest test-accidental-basis-delay
+  (with-test-dir "test-data/p1"
+    (api/set-project-root! (.getAbsolutePath *test-dir*))
+    (is (thrown? clojure.lang.ExceptionInfo
+          (api/compile-clj {:class-dir "target/classes"
+                            :src-dirs ["src"]
+                            :basis (delay (api/create-basis nil))})))))
+
 (comment
   (run-tests)
   )