Skip to content

Commit 83b4283

Browse files
authored
Console stable (#137)
* The one with fixes for deferred values * Stabilized advanced console.log
1 parent 8fad495 commit 83b4283

4 files changed

Lines changed: 19 additions & 16 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,3 +131,4 @@ dist
131131

132132
.DS_Store
133133
**/.DS_Store
134+
.history

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "remix-development-tools",
33
"description": "Remix development tools - a set of tools for developing/debugging Remix.run apps",
44
"author": "Alem Tuzlak",
5-
"version": "4.2.3",
5+
"version": "4.3.0",
66
"license": "MIT",
77
"keywords": [
88
"remix",

src/test-apps/remix-vite/app/routes/_index.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import { Button } from "../components/Button";
66
class Redis {
77
constructor(url: string, options: any) {
88
console.log("Redis constructor", url, options);
9-
9+
console.error("Redis constructor", url, options);
10+
1011
}
1112
on(event: string, cb: any) {
1213
console.log("Redis on", event, cb);
@@ -39,12 +40,17 @@ redis.on("error", console.error);
3940
*/
4041
export const loader = async ({ request , response }: LoaderFunctionArgs) => {
4142

42-
const test = new Promise((resolve) => {
43+
const test = new Promise((resolve, reject) => {
4344
setTimeout(() => {
4445
resolve("test");
4546
}, 1000);
4647
})
47-
return defer({ message: "Hello World!", test });
48+
const test1 = new Promise((resolve, reject) => {
49+
setTimeout(() => {
50+
reject("test");
51+
}, 1000);
52+
})
53+
return defer({ message: "Hello World!", test, test1 });
4854
};
4955

5056

src/vite/plugin.tsx

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ type RemixViteConfig = {
2323
server?: DevToolsServerConfig,
2424
pluginDir?: string;
2525
includeInProd?: boolean;
26-
unstable_console?: boolean;
26+
improvedConsole?: boolean;
2727
};
2828

2929
export const defineRdtConfig = (config: RemixViteConfig) => config
@@ -32,7 +32,7 @@ export const remixDevTools: (args?:RemixViteConfig) => Plugin[] = (args) => {
3232
const serverConfig = args?.server || {};
3333
const clientConfig = args?.client || {};
3434
const include = args?.includeInProd ?? false;
35-
const unstable_console = args?.unstable_console ?? false;
35+
const improvedConsole = args?.improvedConsole ?? true;
3636
const shouldInject = (mode: string | undefined) => mode === "development" || include;
3737
let port = 5173;
3838
return [
@@ -97,7 +97,7 @@ export const remixDevTools: (args?:RemixViteConfig) => Plugin[] = (args) => {
9797
}
9898
},
9999
},
100-
...(unstable_console ? [{
100+
...(improvedConsole ? [{
101101
name: "better-console-logs",
102102
enforce: "pre",
103103
apply(config){
@@ -119,18 +119,14 @@ export const remixDevTools: (args?:RemixViteConfig) => Plugin[] = (args) => {
119119
}
120120

121121
const column = line.indexOf("console.");
122-
const logMessage = `"${chalk.magenta("LOG")} Logged in ${chalk.blueBright(`${id.replace(normalizePath(process.cwd()),"")}:${lineNumber+1}:${column+1}`)}"`;
122+
const logMessage = `"${chalk.magenta("LOG")} ${chalk.blueBright(`${id.replace(normalizePath(process.cwd()),"")}:${lineNumber+1}:${column+1}`)} ↓\\n → "`;
123123
if (line.includes("console.log(")) {
124-
const newLine = `console.log(${logMessage});console.log`;
125-
return line.replace("console.log", newLine);
124+
const newLine = `console.log(${logMessage},`;
125+
return line.replace("console.log(", newLine);
126126
}
127127
else if (line.includes("console.error(")) {
128-
const newLine = `console.error(${logMessage});console.error`;
129-
return line.replace("console.error", newLine);
130-
}
131-
else if (line.includes("console.table(")) {
132-
const newLine = `console.table(${logMessage});console.table`;
133-
return line.replace("console.table",newLine);
128+
const newLine = `console.error(${logMessage},`;
129+
return line.replace("console.error(", newLine);
134130
}
135131
return line;
136132
}).join("\n");

0 commit comments

Comments
 (0)