Skip to content

Commit c1e837b

Browse files
ai: apply changes for #565 (1 review thread)
Addresses: - #4477590259 at lib/DBSQLLogger.ts:64 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent 1c1d1ea commit c1e837b

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎lib/DBSQLLogger.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,10 @@ export default class DBSQLLogger implements IDBSQLLogger {
5959
if (error) {
6060
// Logged at `error` so the console transport's level filter can never
6161
// drop it (e.g. when the logger is configured with `level: error`).
62-
// The message is explicitly marked non-fatal so log-based alerting /
63-
// readers don't mistake this config fallback for a driver failure.
62+
// Trade-off: consumers filtering on the winston `level` field (e.g.
63+
// error-level alerting) WILL see this as an error; the "[warn] ...
64+
// non-fatal" wording only helps human readers tell this config
65+
// fallback apart from a driver failure.
6466
this.logger.log({
6567
level: LogLevel.error,
6668
message: `[warn] Cannot write to log file ${filename}, logging to console only (non-fatal, driver continues normally): ${error.message}`,

0 commit comments

Comments
 (0)