Skip to content

Commit 34572ef

Browse files
committed
refactor: remove delete & redeploy hint
1 parent fede8df commit 34572ef

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

e2e/tests/devspacehelper/inject.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ var _ = DevSpaceDescribe("devspacehelper", func() {
6868
pods, err = kubeClient.RawClient().CoreV1().Pods(ns).List(context.TODO(), metav1.ListOptions{LabelSelector: "app=curl-container"})
6969
if err != nil {
7070
return false, err
71+
} else if len(pods.Items) == 0 || len(pods.Items[0].Status.ContainerStatuses) == 0 {
72+
return false, nil
7173
}
7274
return pods.Items[0].Status.ContainerStatuses[0].Ready, nil
7375
})

pkg/devspace/deploy/deployer/helm/deploy.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
"github.com/loft-sh/devspace/pkg/devspace/helm"
1818
hashpkg "github.com/loft-sh/devspace/pkg/util/hash"
1919
"github.com/loft-sh/devspace/pkg/util/yamlutil"
20-
"github.com/mgutz/ansi"
2120
"github.com/pkg/errors"
2221
)
2322

@@ -144,7 +143,7 @@ func (d *DeployConfig) internalDeploy(overwriteValues map[interface{}]interface{
144143
// Deploy chart
145144
appRelease, err := d.Helm.InstallChart(releaseName, releaseNamespace, overwriteValues, d.DeploymentConfig.Helm)
146145
if err != nil {
147-
return nil, errors.Errorf("Unable to deploy helm chart: %v\nRun `%s` and `%s` to recreate the chart", err, ansi.Color("devspace purge -d "+d.DeploymentConfig.Name, "white+b"), ansi.Color("devspace deploy", "white+b"))
146+
return nil, errors.Errorf("Unable to deploy helm chart: %v", err)
148147
}
149148

150149
// Print revision

0 commit comments

Comments
 (0)