Skip to content

Commit 57e55d7

Browse files
author
Alexis Sellier
committed
feat: add a parameter to disable helm dependency update
Signed-off-by: Alexis Sellier <alexis.sellier@ankorstore.com>
1 parent aceb912 commit 57e55d7

6 files changed

Lines changed: 26 additions & 2 deletions

File tree

devspace-schema.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -744,6 +744,10 @@
744744
},
745745
"type": "array",
746746
"description": "TemplateArgs are additional arguments to pass to `helm template`"
747+
},
748+
"disableDependencyUpdate" : {
749+
"type": "boolean",
750+
"description" : "DisableDependencyUpdate disables helm dependencies update"
747751
}
748752
},
749753
"type": "object",
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
2+
<details className="config-field" data-expandable="false" open>
3+
<summary>
4+
5+
#### `disableDependencyUpdate` <span className="config-field-required" data-required="false">required</span> <span className="config-field-type">boolean</span> <span className="config-field-default">false</span> <span className="config-field-enum"></span> {#deployments-helm-disableDependencyUpdate}
6+
7+
DisableDependencyUpdate disables helm dependencies update
8+
9+
</summary>
10+
11+
12+
</details>

docs/pages/configuration/_partials/v2beta1/deployments/helm_reference.mdx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import PartialValuesFiles from "./helm/valuesFiles.mdx"
66
import PartialDisplayOutput from "./helm/displayOutput.mdx"
77
import PartialUpgradeArgs from "./helm/upgradeArgs.mdx"
88
import PartialTemplateArgs from "./helm/templateArgs.mdx"
9+
import PartialDisableDependencyUpdate from "./helm/disableDependencyUpdate.mdx"
910

1011
<PartialReleaseName />
1112

@@ -39,3 +40,5 @@ Chart holds the chart configuration and where DevSpace can find the chart
3940

4041

4142
<PartialTemplateArgs />
43+
44+
<PartialDisableDependencyUpdate />

docs/schemas/config-openapi.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -752,6 +752,10 @@
752752
},
753753
"type": "array",
754754
"description": "TemplateArgs are additional arguments to pass to `helm template`"
755+
},
756+
"disableDependencyUpdate" : {
757+
"type": "boolean",
758+
"description" : "DisableDependencyUpdate disables helm dependencies update"
755759
}
756760
},
757761
"type": "object",

pkg/devspace/config/versions/latest/schema.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -840,6 +840,9 @@ type HelmConfig struct {
840840
UpgradeArgs []string `yaml:"upgradeArgs,omitempty" json:"upgradeArgs,omitempty"`
841841
// TemplateArgs are additional arguments to pass to `helm template`
842842
TemplateArgs []string `yaml:"templateArgs,omitempty" json:"templateArgs,omitempty"`
843+
844+
// DisableDependencyUpdate disables helm dependencies update, default to false
845+
DisableDependencyUpdate *bool `yaml:"disableDependencyUpdate" json:"disableDependencyUpdate"`
843846
}
844847

845848
// ChartConfig defines the helm chart options

pkg/devspace/helm/v3/client.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ func (c *client) InstallChart(ctx devspacecontext.Context, releaseName string, r
112112
if err == nil && stat.IsDir() {
113113
args = append(args, "--dependency-update")
114114
}
115-
116115
// Upgrade options
117116
args = append(args, helmConfig.UpgradeArgs...)
118117
output, err := c.genericHelm.Exec(ctx, args)
@@ -194,7 +193,6 @@ func (c *client) Template(ctx devspacecontext.Context, releaseName, releaseNames
194193
if err == nil && stat.IsDir() {
195194
args = append(args, "--dependency-update")
196195
}
197-
198196
args = append(args, helmConfig.TemplateArgs...)
199197
result, err := c.genericHelm.Exec(ctx, args)
200198
if err != nil {

0 commit comments

Comments
 (0)