feat: fix list releases issue

Author: FabianKramm

pkg/devspace/deploy/deployer/helm/deploy.go

@@ -29,6 +29,11 @@ func (d *DeployConfig) Deploy(ctx *devspacecontext.Context, forceDeploy bool) (b
 		hash        = ""
 	)
 
+	releaseNamespace := d.DeploymentConfig.Namespace
+	if releaseNamespace == "" {
+		releaseNamespace = ctx.KubeClient.Namespace()
+	}
+
 	// Hash the chart directory if there is any
 	_, err := os.Stat(ctx.ResolvePath(chartPath))
 	if err == nil {
@@ -96,7 +101,7 @@ func (d *DeployConfig) Deploy(ctx *devspacecontext.Context, forceDeploy bool) (b
 
 	forceDeploy = forceDeploy || redeploy || deployCache.DeploymentConfigHash != deploymentConfigHash || helmCache.ValuesHash != deployValuesHash || helmCache.OverridesHash != helmOverridesHash || helmCache.ChartHash != hash
 	if !forceDeploy {
-		releases, err := d.Helm.ListReleases(ctx)
+		releases, err := d.Helm.ListReleases(ctx, releaseNamespace)
 		if err != nil {
 			return false, err
 		}
@@ -119,11 +124,7 @@ func (d *DeployConfig) Deploy(ctx *devspacecontext.Context, forceDeploy bool) (b
 
 		deployCache.DeploymentConfigHash = deploymentConfigHash
 		helmCache.Release = releaseName
-		if d.DeploymentConfig.Namespace != "" {
-			helmCache.ReleaseNamespace = d.DeploymentConfig.Namespace
-		} else {
-			helmCache.ReleaseNamespace = ctx.KubeClient.Namespace()
-		}
+		helmCache.ReleaseNamespace = releaseNamespace
 		helmCache.ChartHash = hash
 		helmCache.ValuesHash = deployValuesHash
 		helmCache.OverridesHash = helmOverridesHash

pkg/devspace/deploy/deployer/helm/status.go

@@ -24,7 +24,7 @@ func (d *DeployConfig) Status(ctx *devspacecontext.Context) (*deployer.StatusRes
 	}
 
 	// Get all releases
-	releases, err := d.Helm.ListReleases(ctx)
+	releases, err := d.Helm.ListReleases(ctx, ctx.KubeClient.Namespace())
 	if err != nil {
 		return &deployer.StatusResult{
 			Name:   d.DeploymentConfig.Name,

pkg/devspace/helm/types/interface.go

@@ -10,7 +10,7 @@ type Client interface {
 	InstallChart(ctx *devspacecontext.Context, releaseName string, releaseNamespace string, values map[string]interface{}, helmConfig *latest.HelmConfig) (*Release, error)
 	Template(ctx *devspacecontext.Context, releaseName, releaseNamespace string, values map[string]interface{}, helmConfig *latest.HelmConfig) (string, error)
 	DeleteRelease(ctx *devspacecontext.Context, releaseName string, releaseNamespace string) error
-	ListReleases(ctx *devspacecontext.Context) ([]*Release, error)
+	ListReleases(ctx *devspacecontext.Context, releaseNamespace string) ([]*Release, error)
 }
 
 // Release is the helm release struct

pkg/devspace/helm/v3/client.go

@@ -88,7 +88,7 @@ func (c *client) InstallChart(ctx *devspacecontext.Context, releaseName string,
 		return nil, err
 	}
 
-	releases, err := c.ListReleases(ctx)
+	releases, err := c.ListReleases(ctx, releaseNamespace)
 	if err != nil {
 		return nil, err
 	}
@@ -157,11 +157,11 @@ func (c *client) DeleteRelease(ctx *devspacecontext.Context, releaseName string,
 	return nil
 }
 
-func (c *client) ListReleases(ctx *devspacecontext.Context) ([]*types.Release, error) {
+func (c *client) ListReleases(ctx *devspacecontext.Context, namespace string) ([]*types.Release, error) {
 	args := []string{
 		"list",
 		"--namespace",
-		ctx.KubeClient.Namespace(),
+		namespace,
 		"--max",
 		strconv.Itoa(0),
 		"--output",

pkg/devspace/pipeline/engine/basichandler/handler.go

@@ -67,6 +67,12 @@ func NewBasicExecHandler() types.ExecHandler {
 type execHandler struct{}
 
 func (e *execHandler) ExecHandler(ctx context.Context, args []string) error {
+	select {
+	case <-ctx.Done():
+		return interp.NewExitStatus(255)
+	default:
+	}
+
 	if len(args) > 0 {
 		hc := interp.HandlerCtx(ctx)
 

pkg/devspace/pipeline/engine/pipelinehandler/handler.go

@@ -93,14 +93,19 @@ type execHandler struct {
 }
 
 func (e *execHandler) ExecHandler(ctx context.Context, args []string) error {
+	select {
+	case <-ctx.Done():
+		return interp.NewExitStatus(255)
+	default:
+	}
+
 	if len(args) > 0 {
 		// handle special pipeline commands
 		handled, err := e.handlePipelineCommands(ctx, args[0], args[1:])
 		if handled || err != nil {
 			return err
 		}
 	}
-
 	return e.basicHandler.ExecHandler(ctx, args)
 }