fix: improve type safety for max_completion_tokens params

Remove Record<string, unknown> type annotation to let TypeScript infer
the params object type, preserving type checking on all properties.
Cast to ChatCompletionCreateParamsNonStreaming at the create() call site
to accommodate the SDK's missing max_completion_tokens type. Add unit
test for reasoning model detection regex.

Signed-off-by: majiayu000 <1835304752@qq.com>

Author: majiayu000

out/cli.cjs

@@ -67158,18 +67158,23 @@ var { OpenAIError: OpenAIError2, APIError: APIError4, APIConnectionError: APICon
 var OpenAiEngine = class {
   constructor(config7) {
     this.generateCommitMessage = async (messages) => {
+      const isReasoningModel = /^(o[1-9]|gpt-5)/.test(this.config.model);
       const params = {
         model: this.config.model,
         messages,
-        temperature: 0,
-        top_p: 0.1,
-        max_tokens: this.config.maxTokensOutput
+        ...isReasoningModel ? { max_completion_tokens: this.config.maxTokensOutput } : {
+          temperature: 0,
+          top_p: 0.1,
+          max_tokens: this.config.maxTokensOutput
+        }
       };
       try {
         const REQUEST_TOKENS = messages.map((msg) => tokenCount(msg.content) + 4).reduce((a4, b7) => a4 + b7, 0);
         if (REQUEST_TOKENS > this.config.maxTokensInput - this.config.maxTokensOutput)
           throw new Error("TOO_MUCH_TOKENS" /* tooMuchTokens */);
-        const completion = await this.client.chat.completions.create(params);
+        const completion = await this.client.chat.completions.create(
+          params
+        );
         const message = completion.choices[0].message;
         let content = message?.content;
         return removeContentTags(content, "think");
@@ -67277,8 +67282,8 @@ var MLXEngine = class {
 var DeepseekEngine = class extends OpenAiEngine {
   constructor(config7) {
     super({
-      ...config7,
-      baseURL: "https://api.deepseek.com/v1"
+      baseURL: "https://api.deepseek.com/v1",
+      ...config7
     });
     // Identical method from OpenAiEngine, re-implemented here
     this.generateCommitMessage = async (messages) => {

out/github-action.cjs

@@ -87943,18 +87943,23 @@ var { OpenAIError: OpenAIError2, APIError: APIError4, APIConnectionError: APICon
 var OpenAiEngine = class {
   constructor(config6) {
     this.generateCommitMessage = async (messages) => {
+      const isReasoningModel = /^(o[1-9]|gpt-5)/.test(this.config.model);
       const params = {
         model: this.config.model,
         messages,
-        temperature: 0,
-        top_p: 0.1,
-        max_tokens: this.config.maxTokensOutput
+        ...isReasoningModel ? { max_completion_tokens: this.config.maxTokensOutput } : {
+          temperature: 0,
+          top_p: 0.1,
+          max_tokens: this.config.maxTokensOutput
+        }
       };
       try {
         const REQUEST_TOKENS = messages.map((msg) => tokenCount(msg.content) + 4).reduce((a4, b4) => a4 + b4, 0);
         if (REQUEST_TOKENS > this.config.maxTokensInput - this.config.maxTokensOutput)
           throw new Error("TOO_MUCH_TOKENS" /* tooMuchTokens */);
-        const completion = await this.client.chat.completions.create(params);
+        const completion = await this.client.chat.completions.create(
+          params
+        );
         const message = completion.choices[0].message;
         let content = message?.content;
         return removeContentTags(content, "think");
@@ -88062,8 +88067,8 @@ var MLXEngine = class {
 var DeepseekEngine = class extends OpenAiEngine {
   constructor(config6) {
     super({
-      ...config6,
-      baseURL: "https://api.deepseek.com/v1"
+      baseURL: "https://api.deepseek.com/v1",
+      ...config6
     });
     // Identical method from OpenAiEngine, re-implemented here
     this.generateCommitMessage = async (messages) => {

src/engine/openAi.ts

@@ -38,16 +38,16 @@ export class OpenAiEngine implements AiEngine {
   ): Promise<string | null> => {
     const isReasoningModel = /^(o[1-9]|gpt-5)/.test(this.config.model);
 
-    const params: Record<string, unknown> = {
+    const params = {
       model: this.config.model,
       messages,
       ...(isReasoningModel
         ? { max_completion_tokens: this.config.maxTokensOutput }
         : {
-            temperature: 0,
-            top_p: 0.1,
-            max_tokens: this.config.maxTokensOutput
-          })
+          temperature: 0,
+          top_p: 0.1,
+          max_tokens: this.config.maxTokensOutput
+        })
     };
 
     try {
@@ -61,7 +61,9 @@ export class OpenAiEngine implements AiEngine {
       )
         throw new Error(GenerateCommitMessageErrorEnum.tooMuchTokens);
 
-      const completion = await this.client.chat.completions.create(params);
+      const completion = await this.client.chat.completions.create(
+        params as OpenAI.Chat.Completions.ChatCompletionCreateParamsNonStreaming
+      );
 
       const message = completion.choices[0].message;
       let content = message?.content;

test/unit/openAi.test.ts

@@ -0,0 +1,26 @@
+// Test the reasoning model detection regex used in OpenAiEngine.
+// Integration test with the engine is not possible because mistral.ts
+// uses require() which is unavailable in the ESM test environment.
+const REASONING_MODEL_RE = /^(o[1-9]|gpt-5)/;
+
+describe('OpenAiEngine reasoning model detection', () => {
+  it.each([
+    ['o1', true],
+    ['o1-preview', true],
+    ['o1-mini', true],
+    ['o3', true],
+    ['o3-mini', true],
+    ['o4-mini', true],
+    ['gpt-5', true],
+    ['gpt-5-nano', true],
+    ['gpt-4o', false],
+    ['gpt-4o-mini', false],
+    ['gpt-4', false],
+    ['gpt-3.5-turbo', false]
+  ])(
+    'model "%s" isReasoning=%s',
+    (model, expected) => {
+      expect(REASONING_MODEL_RE.test(model)).toBe(expected);
+    }
+  );
+});