Extend NuGet package validation

- Use Meziantou.Framework.NuGetPackageValidation.Tool to extend NuGet package validation.
- Use consistent PowerShell environment variable syntax.

Author: martincostello

.config/dotnet-tools.json

@@ -6,13 +6,22 @@
       "version": "0.0.1-preview.537",
       "commands": [
         "dotnet-validate"
-      ]
+      ],
+      "rollForward": false
     },
     "markdownsnippets.tool": {
       "version": "27.0.2",
       "commands": [
         "mdsnippets"
-      ]
+      ],
+      "rollForward": false
+    },
+    "meziantou.framework.nugetpackagevalidation.tool": {
+      "version": "1.0.31",
+      "commands": [
+        "meziantou.validate-nuget-package"
+      ],
+      "rollForward": false
     }
   }
 }

.github/bump-version.ps1

@@ -48,7 +48,7 @@ try {
     $writer = $null
 }
 
-$githubOutput = $env:GITHUB_OUTPUT
+$githubOutput = ${env:GITHUB_OUTPUT}
 
 if (($null -ne $githubOutput) -and (Test-Path $githubOutput)) {
   "version=${updatedVersion}" >> $githubOutput

.github/workflows/build.yml

@@ -29,6 +29,7 @@ jobs:
     outputs:
       dotnet-sdk-version: ${{ steps.setup-dotnet.outputs.dotnet-version }}
       dotnet-validate-version: ${{ steps.get-dotnet-tools-versions.outputs.dotnet-validate-version }}
+      nuget-package-validation-version: ${{ steps.get-dotnet-tools-versions.outputs.nuget-package-validation-version }}
       package-names: ${{ steps.build.outputs.package-names }}
       package-version: ${{ steps.build.outputs.package-version }}
 
@@ -148,7 +149,9 @@ jobs:
       run: |
         $manifest = (Get-Content "./.config/dotnet-tools.json" | Out-String | ConvertFrom-Json)
         $dotnetValidateVersion = $manifest.tools.'dotnet-validate'.version
-        "dotnet-validate-version=${dotnetValidateVersion}" >> $env:GITHUB_OUTPUT
+        $nugetPackageValidationVersion = $manifest.tools.'meziantou.framework.nugetpackagevalidation.tool'.version
+        "dotnet-validate-version=${dotnetValidateVersion}" >> ${env:GITHUB_OUTPUT}
+        "nuget-package-validation-version=${nugetPackageValidationVersion}" >> ${env:GITHUB_OUTPUT}
 
   validate-packages:
     needs: build
@@ -165,17 +168,33 @@ jobs:
       with:
         dotnet-version: ${{ needs.build.outputs.dotnet-sdk-version }}
 
-    - name: Validate NuGet packages
+    - name: Install NuGet package validation tools
       shell: pwsh
       env:
         DOTNET_VALIDATE_VERSION: ${{ needs.build.outputs.dotnet-validate-version }}
+        NUGET_PACKAGE_VALIDATION_VERSION: ${{ needs.build.outputs.nuget-package-validation-version }}
       run: |
         dotnet tool install --global dotnet-validate --version ${env:DOTNET_VALIDATE_VERSION} --allow-roll-forward
+        dotnet tool install --global Meziantou.Framework.NuGetPackageValidation.Tool --version ${env:NUGET_PACKAGE_VALIDATION_VERSION} --allow-roll-forward
+
+    - name: Validate NuGet packages
+      shell: pwsh
+      env:
+        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      run: |
         $packages = Get-ChildItem -Filter "*.nupkg" | ForEach-Object { $_.FullName }
         $invalidPackages = 0
         foreach ($package in $packages) {
+          $isValid = $true
           dotnet validate package local $package
           if ($LASTEXITCODE -ne 0) {
+            $isValid = $false
+          }
+          meziantou.validate-nuget-package $package --github-token ${env:GH_TOKEN} --excluded-rules IconMustBeSet
+          if ($LASTEXITCODE -ne 0) {
+            $isValid = $false
+          }
+          if (-Not $isValid) {
             $invalidPackages++
           }
         }

.github/workflows/bump-version.yml

@@ -79,9 +79,9 @@ jobs:
           git commit -m "Bump version`n`nBump version to ${env:NEXT_VERSION} for the next release." -s
           git push -u origin $branchName
 
-          "branch-name=${branchName}" >> $env:GITHUB_OUTPUT
-          "updated-version=true" >> $env:GITHUB_OUTPUT
-          "version=${env:NEXT_VERSION}" >> $env:GITHUB_OUTPUT
+          "branch-name=${branchName}" >> ${env:GITHUB_OUTPUT}
+          "updated-version=true" >> ${env:GITHUB_OUTPUT}
+          "version=${env:NEXT_VERSION}" >> ${env:GITHUB_OUTPUT}
 
       - name: Create pull request
         if: steps.push-changes.outputs.updated-version == 'true'

.github/workflows/release.yml

@@ -39,7 +39,7 @@ jobs:
           $properties = Join-Path "." "Directory.Build.props"
           $xml = [xml](Get-Content $properties)
           $version = $xml.SelectSingleNode('Project/PropertyGroup/VersionPrefix').InnerText
-          "version=${version}" >> $env:GITHUB_OUTPUT
+          "version=${version}" >> ${env:GITHUB_OUTPUT}
 
       - name: Create release
         uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0

build.ps1

@@ -18,7 +18,7 @@ if ($LASTEXITCODE -ne 0) {
 
 $additionalArgs = @()
 
-if (![string]::IsNullOrEmpty($env:GITHUB_SHA)) {
+if (![string]::IsNullOrEmpty(${env:GITHUB_SHA})) {
     $additionalArgs += "--logger:GitHubActions;report-warnings=false"
     $additionalArgs += "--logger:junit;LogFilePath=junit.xml"
 }