tests(phpstan): Enable level 3 checking (#1098)

Author: klausi

examples/graphql_composable/src/GraphQL/Response/ArticleResponse.php

@@ -13,7 +13,7 @@ class ArticleResponse extends Response {
   /**
    * The article to be served.
    *
-   * @var \Drupal\Core\Entity\ContentEntityInterface|null
+   * @var \Drupal\Core\Entity\EntityInterface|null
    */
   protected $article;
 
@@ -30,7 +30,7 @@ public function setArticle(?EntityInterface $article): void {
   /**
    * Gets the article to be served.
    *
-   * @return \Drupal\Core\Entity\ContentEntityInterface|null
+   * @return \Drupal\Core\Entity\EntityInterface|null
    *   The article to be served.
    */
   public function article(): ?EntityInterface {

examples/graphql_composable/src/Wrappers/Response/ArticleResponse.php

@@ -15,7 +15,7 @@ class ArticleResponse extends Response {
   /**
    * The article to be served.
    *
-   * @var \Drupal\Core\Entity\ContentEntityInterface|null
+   * @var \Drupal\Core\Entity\EntityInterface|null
    */
   protected $article;
 
@@ -32,7 +32,7 @@ public function setArticle(?EntityInterface $article): void {
   /**
    * Gets the article to be served.
    *
-   * @return \Drupal\Core\Entity\ContentEntityInterface|null
+   * @return \Drupal\Core\Entity\EntityInterface|null
    *   The article to be served.
    */
   public function article(): ?EntityInterface {

examples/graphql_example/src/Wrappers/QueryConnection.php

@@ -8,7 +8,7 @@
 class QueryConnection {
 
   /**
-   * @var \Drupal\Core\Entity\Query\Sql\Query
+   * @var \Drupal\Core\Entity\Query\QueryInterface
    */
   protected $query;
 

phpstan.neon

@@ -8,7 +8,7 @@ parameters:
 	# PHPStan cannot find files in this test directory automatically.
 	scanDirectories:
 		- ../../core/tests/Drupal/Tests
-	level: 2
+	level: 3
 	customRulesetUsed: true
 	paths:
 		- .
@@ -29,3 +29,11 @@ parameters:
 		- "#deprecated class Symfony\\\\Component\\\\EventDispatcher\\\\Event#"
 		- "#deprecated class Symfony\\\\Component\\\\HttpKernel\\\\Event\\\\GetResponseEvent#"
 		- "#^Method Symfony\\\\Contracts\\\\EventDispatcher\\\\EventDispatcherInterface\\:\\:dispatch\\(\\) invoked with 2 parameters, 1 required\\.$#"
+		# Drupal allows object property access to custom fields, so we cannot fix
+		# that.
+		- "#^Property Drupal\\\\.+ \\(Drupal\\\\Core\\\\Field\\\\FieldItemListInterface\\) does not accept .+\\.$#"
+		# Incomplete type doc comments in Drupal core that we have to ignore.
+		-
+			message: "#^Method Drupal\\\\graphql\\\\Plugin\\\\LanguageNegotiation\\\\OperationLanguageNegotiation\\:\\:getLangcode\\(\\) should return string but returns false\\.$#"
+			count: 1
+			path: src/Plugin/LanguageNegotiation/OperationLanguageNegotiation.php

src/Config/LanguageConfigOverride.php

@@ -73,6 +73,9 @@ public function getCacheSuffix() {
    * {@inheritdoc}
    */
   public function createConfigObject($name, $collection = StorageInterface::DEFAULT_COLLECTION) {
+    // The interface says we should return an object here, but we don't care and
+    // this does not seem to break anything?
+    // @phpstan-ignore-next-line
     return NULL;
   }
 

src/Entity/Server.php

@@ -134,14 +134,14 @@ class Server extends ConfigEntityBase implements ServerInterface {
   /**
    * Persisted query plugin instances available on this server.
    *
-   * @var array
+   * @var array|null
    */
   protected $persisted_query_instances = NULL;
 
   /**
    * The sorted persisted query plugin instances available on this server.
    *
-   * @var array
+   * @var array|null
    */
   protected $sorted_persisted_query_instances = NULL;
 

src/Plugin/GraphQL/DataProducer/Entity/EntityChanged.php

@@ -32,7 +32,7 @@ class EntityChanged extends DataProducerPluginBase {
    * @param \Drupal\Core\Entity\EntityInterface $entity
    * @param string|null $format
    *
-   * @return string
+   * @return string|null
    * @throws \Exception
    */
   public function resolve(EntityInterface $entity, $format = NULL) {

src/Plugin/GraphQL/DataProducer/Entity/EntityCreated.php

@@ -31,7 +31,7 @@ class EntityCreated extends DataProducerPluginBase {
    * @param \Drupal\Core\Entity\EntityInterface $entity
    * @param string|null $format
    *
-   * @return string
+   * @return string|null
    */
   public function resolve(EntityInterface $entity, $format = NULL) {
     // `getCreatedTime` is on NodeInterface which feels weird, since there

src/Plugin/GraphQL/DataProducer/Entity/EntityDescription.php

@@ -26,7 +26,7 @@ class EntityDescription extends DataProducerPluginBase {
   /**
    * @param \Drupal\Core\Entity\EntityInterface $entity
    *
-   * @return string
+   * @return string|null
    */
   public function resolve(EntityInterface $entity) {
     if ($entity instanceof EntityDescriptionInterface) {

src/Plugin/GraphQL/DataProducer/Field/EntityReference.php

@@ -64,7 +64,7 @@ class EntityReference extends DataProducerPluginBase implements ContainerFactory
   /**
    * The entity type manager service.
    *
-   * @var \Drupal\Core\Entity\EntityTypeManager
+   * @var \Drupal\Core\Entity\EntityTypeManagerInterface
    */
   protected $entityTypeManager;