Skip to content

Commit 6ed9492

Browse files
blazeyofubhy
authored andcommitted
Fixed the responsive image field plugin and improvaed test coverage. (#353)
1 parent 86e74d0 commit 6ed9492

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

modules/graphql_image/src/Plugin/GraphQL/Fields/ImageResponsive.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ protected function resolveValues($value, array $args, ResolveInfo $info) {
7373
$variables = [
7474
'#theme' => 'responsive_image',
7575
'#responsive_image_style_id' => $args['style'],
76-
'#uri' => $value->uri,
76+
'#uri' => $value->entity->getFileUri(),
7777
];
7878

7979
yield $this->renderer->renderRoot($variables);

modules/graphql_image/tests/src/Kernel/ImageFieldTest.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,13 @@ public function testImageField() {
128128
$this->assertEquals($a->image->alt, $image['alt'], 'Alt text correct.');
129129
$this->assertEquals($a->image->title, $image['title'], 'Title text correct.');
130130
$this->assertEquals($a->image->entity->url(), $image['url'], 'Retrieve correct image url.');
131-
$this->assertNotEmpty(trim($image['responsive']), 'Responsive image returned.');
131+
132+
/**
133+
* Responsive image output should contain the name of the file.
134+
*
135+
* @see \Drupal\image\Plugin\Field\FieldType\ImageItem::generateSampleValue()
136+
*/
137+
$this->assertContains('generateImage', $image['responsive'], 'Proper responsive image returned.');
132138
}
133139

134140
}

0 commit comments

Comments
 (0)