tests(menu): Fix undefined variable in test (#1076)

Author: klausi

phpcs.xml.dist

@@ -20,7 +20,6 @@
 
   <rule ref="DrupalPractice.CodeAnalysis.VariableAnalysis.UndefinedVariable">
     <exclude-pattern>src/Plugin/GraphQL/DataProducer/Field/EntityReference.php</exclude-pattern>
-    <exclude-pattern>tests/src/Kernel/DataProducer/MenuTest.php</exclude-pattern>
   </rule>
 
   <!-- TODO: those rules are disabled for now until we fix the coding standards for them. -->

tests/src/Kernel/DataProducer/MenuTest.php

@@ -143,16 +143,20 @@ public function testMenuTreeSubtree() {
    */
   public function testMenuLinkAttribute() {
     $attribute = 'target';
+    $assert_happened = FALSE;
     foreach ($this->linkTree as $link_tree) {
+      $options = $link_tree->link->getOptions();
       if (!empty($options['attributes'][$attribute])) {
         $result = $this->executeDataProducer('menu_link_attribute', [
           'link' => $link_tree->link,
           'attribute' => 'target',
         ]);
 
         $this->assertEquals($options['attributes'][$attribute], $result);
+        $assert_happened = TRUE;
       }
     }
+    $this->assertTrue($assert_happened, 'At least one menu attribute was tested');
   }
 
   /**