tests(Travis CI): Switch testing to Drupal 8.9.x and 9.0.x (#1081)

Author: klausi

.travis.yml

@@ -16,22 +16,25 @@ env:
     - SIMPLETEST_DB=mysql://root:@127.0.0.1/graphql
     - TRAVIS=true
   matrix:
-    - DRUPAL_CORE=8.8.x
+    - DRUPAL_CORE=8.9.x
 
 matrix:
   # Don't wait for the allowed failures to build.
   fast_finish: true
   include:
-    - php: 7.2
+    - php: 7.4
       env:
-        - DRUPAL_CORE=8.8.x
+        - DRUPAL_CORE=8.9.x
         # Only run code coverage on the latest php and drupal versions.
         - WITH_PHPDBG_COVERAGE=true
+    - php: 7.4
+      env:
+        - DRUPAL_CORE=9.0.x
   allow_failures:
     # Allow the code coverage report to fail.
-    - php: 7.2
+    - php: 7.4
       env:
-        - DRUPAL_CORE=8.8.x
+        - DRUPAL_CORE=8.9.x
         # Only run code coverage on the latest php and drupal versions.
         - WITH_PHPDBG_COVERAGE=true
 
@@ -113,7 +116,7 @@ script:
   - if [[ "$WITH_PHPDBG_COVERAGE" != "true" ]];
       then $DRUPAL_BUILD_DIR/vendor/bin/phpunit --configuration $DRUPAL_BUILD_DIR/core/phpunit.xml $TRAVIS_BUILD_DIR;
     fi
-  
+
   # Run Phpstan
   - cd $DRUPAL_BUILD_DIR/modules/graphql && $DRUPAL_BUILD_DIR/vendor/bin/phpstan analyse
 

phpstan.neon

@@ -7,6 +7,9 @@ parameters:
 	customRulesetUsed: true
 	paths:
 		- .
+	# We test with PHPStan on Drupal 8 and 9 and might have different ignored
+	# errors on both.
+	reportUnmatchedIgnoredErrors: false
 	ignoreErrors:
 		# @todo Ignore phpstan-drupal extension's rules for now, activate later.
 		- '#\Drupal calls should be avoided in classes, use dependency injection instead#'
@@ -15,3 +18,8 @@ parameters:
 		# Drupal allows object property access to custom fields, so we cannot fix
 		# that.
 		- "#^Access to an undefined property Drupal\\\\#"
+		# PHPUnit deprecation warnings in Drupal 9 that we don't care about.
+		- "#^Call to deprecated method setMethods\\(\\) of class PHPUnit\\\\Framework\\\\MockObject\\\\MockBuilder:#"
+		# Symfony 4 deprecations in Drupal 9 that we don't care about.
+		- "#deprecated class Symfony\\\\Component\\\\EventDispatcher\\\\Event#"
+		- "#deprecated class Symfony\\\\Component\\\\HttpKernel\\\\Event\\\\GetResponseEvent#"

tests/modules/graphql_persisted_queries_test/graphql_persisted_queries_test.info.yml

@@ -2,7 +2,7 @@ type: module
 name: GraphQL Persisted Queries Test
 description: Tests the graphql persisted queries functionality.
 package: Testing
-core: 8.x
+core_version_requirement: ^8 || ^9
 hidden: TRUE
 dependencies:
   - graphql:graphql

tests/src/Kernel/DataProducer/EntityTest.php

@@ -377,7 +377,7 @@ public function testResolveEntityRendered() {
 
     // TODO: Add metadata check.
     // $this->assertContains('node:1', $metadata->getCacheTags());
-    $this->assertContains('<a href="/node/1" rel="bookmark"><span>' . $this->node->getTitle() . '</span>', $result);
+    $this->assertStringContainsString('<a href="/node/1" rel="bookmark"><span>' . $this->node->getTitle() . '</span>', $result);
   }
 
 }